fix tests

Author: jeromevdl

powertools-cloudformation/src/test/java/software/amazon/lambda/powertools/cloudformation/CloudFormationResponseTest.java

@@ -38,7 +38,7 @@
 import software.amazon.awssdk.utils.StringInputStream;
 import software.amazon.lambda.powertools.cloudformation.CloudFormationResponse.ResponseBody;
 
-public class CloudFormationResponseTest {
+class CloudFormationResponseTest {
 
     /**
      * Creates a mock CloudFormationCustomResourceEvent with a non-null response URL.
@@ -215,7 +215,7 @@ void reasonIncludesLogStreamName() {
     }
 
     @Test
-    public void sendWithNoResponseData() throws Exception {
+    void sendWithNoResponseData() throws Exception {
         CloudFormationCustomResourceEvent event = mockCloudFormationCustomResourceEvent();
         Context context = mock(Context.class);
         CloudFormationResponse cfnResponse = testableCloudFormationResponse();
@@ -237,7 +237,7 @@ public void sendWithNoResponseData() throws Exception {
     }
 
     @Test
-    public void sendWithNonNullResponseData() throws Exception {
+    void sendWithNonNullResponseData() throws Exception {
         CloudFormationCustomResourceEvent event = mockCloudFormationCustomResourceEvent();
         Context context = mock(Context.class);
         CloudFormationResponse cfnResponse = testableCloudFormationResponse();
@@ -289,7 +289,7 @@ void responseBodyStreamSuccessResponse() throws Exception {
         Context context = mock(Context.class);
         CloudFormationResponse cfnResponse = testableCloudFormationResponse();
 
-        StringInputStream stream = cfnResponse.responseBodyStream(event, context, Response.success());
+        StringInputStream stream = cfnResponse.responseBodyStream(event, context, Response.success(null));
 
         String expectedJson = "{" +
                 "\"Status\":\"SUCCESS\"," +
@@ -310,7 +310,7 @@ void responseBodyStreamFailedResponse() throws Exception {
         Context context = mock(Context.class);
         CloudFormationResponse cfnResponse = testableCloudFormationResponse();
 
-        StringInputStream stream = cfnResponse.responseBodyStream(event, context, Response.failed());
+        StringInputStream stream = cfnResponse.responseBodyStream(event, context, Response.failed(null));
 
         String expectedJson = "{" +
                 "\"Status\":\"FAILED\"," +

powertools-cloudformation/src/test/java/software/amazon/lambda/powertools/cloudformation/ResponseTest.java

@@ -22,7 +22,7 @@
 import java.util.Map;
 import org.junit.jupiter.api.Test;
 
-public class ResponseTest {
+class ResponseTest {
 
     @Test
     void defaultValues() {
@@ -92,7 +92,7 @@ void jsonMapValueWithDefaultObjectMapper() {
 
         String expected = "{\"foo\":\"bar\"}";
         assertThat(response.getJsonNode()).isNotNull();
-        assertThat(response.getJsonNode().toString()).isEqualTo(expected);
+        assertThat(response.getJsonNode()).hasToString(expected);
         assertThat(response.toString()).contains("JSON = " + expected);
     }
 
@@ -105,7 +105,7 @@ void jsonObjectValueWithDefaultObjectMapper() {
                 .build();
 
         String expected = "{\"PropertyWithLongName\":\"test\"}";
-        assertThat(response.getJsonNode().toString()).isEqualTo(expected);
+        assertThat(response.getJsonNode()).hasToString(expected);
         assertThat(response.toString()).contains("JSON = " + expected);
     }
 
@@ -119,7 +119,7 @@ void jsonObjectValueWithNullObjectMapper() {
                 .build();
 
         String expected = "{\"PropertyWithLongName\":\"test\"}";
-        assertThat(response.getJsonNode().toString()).isEqualTo(expected);
+        assertThat(response.getJsonNode()).hasToString(expected);
         assertThat(response.toString()).contains("JSON = " + expected);
     }
 
@@ -135,7 +135,7 @@ void jsonObjectValueWithCustomObjectMapper() {
                 .build();
 
         String expected = "{\"property-with-long-name\":10}";
-        assertThat(response.getJsonNode().toString()).isEqualTo(expected);
+        assertThat(response.getJsonNode()).hasToString(expected);
         assertThat(response.toString()).contains("JSON = " + expected);
     }
 
@@ -154,21 +154,21 @@ void jsonObjectValueWithPostConfiguredObjectMapper() {
         customMapper.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);
 
         String expected = "{\"property-with-long-name\":10}";
-        assertThat(response.getJsonNode().toString()).isEqualTo(expected);
+        assertThat(response.getJsonNode()).hasToString(expected);
         assertThat(response.toString()).contains("JSON = " + expected);
     }
 
     @Test
     void successFactoryMethod() {
-        Response response = Response.success();
+        Response response = Response.success(null);
 
         assertThat(response).isNotNull();
         assertThat(response.getStatus()).isEqualTo(Response.Status.SUCCESS);
     }
 
     @Test
     void failedFactoryMethod() {
-        Response response = Response.failed();
+        Response response = Response.failed(null);
 
         assertThat(response).isNotNull();
         assertThat(response.getStatus()).isEqualTo(Response.Status.FAILED);

powertools-cloudformation/src/test/java/software/amazon/lambda/powertools/cloudformation/handlers/NoPhysicalResourceIdSetHandler.java

@@ -23,16 +23,16 @@ public class NoPhysicalResourceIdSetHandler extends AbstractCustomResourceHandle
 
     @Override
     protected Response create(CloudFormationCustomResourceEvent event, Context context) {
-        return Response.success();
+        return Response.success(null);
     }
 
     @Override
     protected Response update(CloudFormationCustomResourceEvent event, Context context) {
-        return Response.success();
+        return Response.success(null);
     }
 
     @Override
     protected Response delete(CloudFormationCustomResourceEvent event, Context context) {
-        return Response.success();
+        return Response.success(null);
     }
 }