Skip to content

Commit 65e136d

Browse files
authored
Merge branch 'v2' into feature/high-res-metrics
2 parents 1693687 + b0af349 commit 65e136d

File tree

9 files changed

+63
-4
lines changed

9 files changed

+63
-4
lines changed

pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@
8989
<log4j.version>2.20.0</log4j.version>
9090
<log4j.version>2.22.0</log4j.version>
9191
<slf4j.version>2.0.7</slf4j.version>
92-
<jackson.version>2.15.3</jackson.version>
92+
<jackson.version>2.16.0</jackson.version>
9393
<aws.sdk.version>2.21.0</aws.sdk.version>
94-
<aws.xray.recorder.version>2.14.0</aws.xray.recorder.version>
94+
<aws.xray.recorder.version>2.15.0</aws.xray.recorder.version>
9595
<payloadoffloading-common.version>2.1.3</payloadoffloading-common.version>
9696
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
9797
<lambda.core.version>1.2.3</lambda.core.version>

powertools-parameters/powertools-parameters-appconfig/src/main/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderBuilder.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ public AppConfigProvider build() {
5151
if (application == null) {
5252
throw new IllegalStateException("No application provided; please provide one");
5353
}
54-
54+
if (transformationManager == null) {
55+
transformationManager = new TransformationManager();
56+
}
5557
// Create a AppConfigDataClient if we haven't been given one
5658
if (client == null) {
5759
client = AppConfigDataClient.builder()

powertools-parameters/powertools-parameters-appconfig/src/test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java

+13
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
1818
import static org.assertj.core.api.Assertions.assertThatRuntimeException;
1919
import static org.assertj.core.api.Assertions.assertThat;
20+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
2021
import static org.mockito.MockitoAnnotations.openMocks;
22+
import static software.amazon.lambda.powertools.parameters.transform.Transformer.json;
2123

2224
import org.junit.jupiter.api.BeforeEach;
2325
import org.junit.jupiter.api.Test;
@@ -216,4 +218,15 @@ public void testAppConfigProviderBuilderMissingApplication_throwsException() {
216218
.build())
217219
.withMessage("No application provided; please provide one");
218220
}
221+
@Test
222+
public void testAppConfigProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
223+
224+
// Act
225+
AppConfigProvider appConfigProvider = AppConfigProvider.builder()
226+
.withEnvironment("test")
227+
.withApplication("app")
228+
.build();
229+
// Assert
230+
assertDoesNotThrow(()->appConfigProvider.withTransformation(json));
231+
}
219232
}

powertools-parameters/powertools-parameters-dynamodb/src/main/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderBuilder.java

+3
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ public DynamoDbProvider build() {
6161
if (client == null) {
6262
client = createClient();
6363
}
64+
if (transformationManager == null) {
65+
transformationManager = new TransformationManager();
66+
}
6467
provider = new DynamoDbProvider(cacheManager, transformationManager, client, table);
6568

6669
return provider;

powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderTest.java

+11
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616

1717
import static org.assertj.core.api.Assertions.assertThat;
1818
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
19+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
1920
import static org.mockito.MockitoAnnotations.openMocks;
21+
import static software.amazon.lambda.powertools.parameters.transform.Transformer.json;
2022

2123
import java.util.HashMap;
2224
import java.util.Map;
@@ -225,5 +227,14 @@ public void testDynamoDBBuilderMissingTable_throwsException() {
225227
.withCacheManager(new CacheManager())
226228
.build());
227229
}
230+
@Test
231+
public void testDynamoDBBuilder_withoutParameter_shouldHaveDefaultTransformationManager() {
232+
233+
// Act
234+
DynamoDbProvider dynamoDbProvider = DynamoDbProvider.builder().withTable("test-table")
235+
.build();
236+
// Assert
237+
assertDoesNotThrow(()->dynamoDbProvider.withTransformation(json));
238+
}
228239

229240
}

powertools-parameters/powertools-parameters-secrets/src/main/java/software/amazon/lambda/powertools/parameters/secrets/SecretsProviderBuilder.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,9 @@ public SecretsProvider build() {
5959
if (client == null) {
6060
client = createClient();
6161
}
62-
62+
if(transformationManager == null){
63+
transformationManager = new TransformationManager();
64+
}
6365
provider = new SecretsProvider(cacheManager, transformationManager, client);
6466

6567
return provider;

powertools-parameters/powertools-parameters-secrets/src/test/java/software/amazon/lambda/powertools/parameters/secrets/SecretsProviderTest.java

+13
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,13 @@
1616

1717
import static org.assertj.core.api.Assertions.assertThat;
1818
import static org.assertj.core.api.Assertions.assertThatRuntimeException;
19+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
1920
import static org.junit.jupiter.api.Assertions.assertNotNull;
21+
import static software.amazon.lambda.powertools.parameters.transform.Transformer.json;
2022

2123
import java.time.temporal.ChronoUnit;
2224
import java.util.Base64;
25+
2326
import org.junit.jupiter.api.BeforeEach;
2427
import org.junit.jupiter.api.Test;
2528
import org.mockito.ArgumentCaptor;
@@ -105,4 +108,14 @@ public void testGetSecretsProvider_withoutParameter_shouldCreateDefaultClient()
105108
assertNotNull(secretsProvider);
106109
assertNotNull(secretsProvider.getClient());
107110
}
111+
112+
@Test
113+
public void testGetSecretsProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
114+
115+
// Act
116+
SecretsProvider secretsProvider = SecretsProvider.builder()
117+
.build();
118+
// Assert
119+
assertDoesNotThrow(()->secretsProvider.withTransformation(json));
120+
}
108121
}

powertools-parameters/powertools-parameters-ssm/src/main/java/software/amazon/lambda/powertools/parameters/ssm/SSMProviderBuilder.java

+3
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ public SSMProvider build() {
5757
client = createClient();
5858
}
5959

60+
if(transformationManager == null){
61+
transformationManager = new TransformationManager();
62+
}
6063
provider = new SSMProvider(cacheManager, transformationManager, client);
6164

6265
return provider;

powertools-parameters/powertools-parameters-ssm/src/test/java/software/amazon/lambda/powertools/parameters/ssm/SSMProviderTest.java

+12
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
import static java.util.Arrays.asList;
1818
import static org.assertj.core.api.Assertions.assertThat;
19+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
20+
import static software.amazon.lambda.powertools.parameters.transform.Transformer.json;
1921

2022
import java.time.temporal.ChronoUnit;
2123
import java.util.ArrayList;
@@ -194,6 +196,16 @@ public void getMultipleWithNextToken() {
194196
assertThat(request2.nextToken()).isEqualTo("123abc");
195197
}
196198

199+
@Test
200+
public void testSSMProvider_withoutParameter_shouldHaveDefaultTransformationManager() {
201+
202+
// Act
203+
SSMProvider ssmProvider = SSMProvider.builder()
204+
.build();
205+
// Assert
206+
assertDoesNotThrow(()->ssmProvider.withTransformation(json));
207+
}
208+
197209
private void initMock(String expectedValue) {
198210
Parameter parameter = Parameter.builder().value(expectedValue).build();
199211
GetParameterResponse result = GetParameterResponse.builder().parameter(parameter).build();

0 commit comments

Comments
 (0)