chore: spotbugs check on pr

Author: Pankaj Agrawal

.github/workflows/spotbugs.yml

@@ -0,0 +1,34 @@
+name: SpotBugs
+
+on:
+  pull_request:
+    branches:
+      - master
+    paths:
+      - 'powertools-core/**'
+      - 'powertools-logging/**'
+      - 'powertools-sqs/**'
+      - 'powertools-tracing/**'
+      - 'powertools-validation/**'
+      - 'powertools-parameters/**'
+      - 'powertools-metrics/**'
+      - 'pom.xml'
+      - '.github/workflows/**'
+jobs:
+  codecheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup java JDK 1.8
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'zulu'
+          java-version: 8
+      - name: Build with Maven for spotbugs check to gather reports
+        run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=false
+      - uses: jwgmeligmeyling/spotbugs-github-action@master
+        with:
+          path: '**/spotbugsXml.xml'
+      # Can be simplified post this issue is fixed https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/9
+      - name: Build with Maven for spotbugs check to mark build as fail if voilations found
+        run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=true

pom.xml

@@ -419,7 +419,6 @@
                         </executions>
                         <configuration>
                             <xmlOutput>true</xmlOutput>
-                            <failOnError>true</failOnError>
                         </configuration>
                     </plugin>
                     <plugin>

powertools-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java

@@ -236,7 +236,7 @@ private Object[] logFromInputStream(final ProceedingJoinPoint pjp) {
 
     private byte[] bytesFromInputStreamSafely(final InputStream inputStream) throws IOException {
         try (ByteArrayOutputStream out = new ByteArrayOutputStream();
-             InputStreamReader reader = new InputStreamReader(inputStream, UTF_8)) {
+             InputStreamReader reader = new InputStreamReader(inputStream)) {
             OutputStreamWriter writer = new OutputStreamWriter(out, UTF_8);
 
             IOUtils.copy(reader, writer);