Address jvdl review comments

Author: scottgerring

docs/utilities/parameters.md

@@ -76,7 +76,7 @@ in order to get data from other regions or use specific credentials.
     }
     ```
 
-=== "SSMProvider with an explicit region"
+=== "SSMProvider with a custom client"
 
     ```java hl_lines="5 7"
     import software.amazon.lambda.powertools.parameters.SSMProvider;
@@ -151,7 +151,7 @@ in order to get data from other regions or use specific credentials.
     }
     ```
 
-=== "SecretsProvider with an explicit region"
+=== "SecretsProvider with a custom client"
 
     ```java hl_lines="5 7"
     import software.amazon.lambda.powertools.parameters.SecretsProvider;
@@ -188,7 +188,7 @@ a `DynamoDbProvider` providing a client if you need to configure it yourself.
     } 
     ```
 
-=== "DynamoDbProvider with an explicit region"
+=== "DynamoDbProvider with a custom client"
 
     ```java hl_lines="9 10 11 12 15 18"
     import software.amazon.lambda.powertools.parameters.DynamoDbProvider;

powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/DynamoDbProvider.java

@@ -53,14 +53,14 @@ protected String getValue(String key) {
         GetItemResponse resp = client.getItem(GetItemRequest.builder()
                 .tableName(tableName)
                 .key(Collections.singletonMap("id", AttributeValue.fromS(key)))
-                .attributesToGet("val")
+                .attributesToGet("value")
                 .build());
 
         // If we have an item at the key, we should be able to get a 'val' out of it. If not it's
         // exceptional.
         // If we don't have an item at the key, we should return null.
         if (resp.hasItem() && !resp.item().values().isEmpty()) {
-            return resp.item().get("val").s();
+            return resp.item().get("value").s();
         }
 
         return null;
@@ -87,7 +87,7 @@ protected Map<String, String> getMultipleValues(String path) {
                     .collect(
                             Collectors.toMap(
                                     (i) -> i.get("sk").s(),
-                                    (i) -> i.get("val").s()));
+                                    (i) -> i.get("value").s()));
 
 
     }

powertools-parameters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderE2ETest.java

@@ -19,7 +19,8 @@
  * of our unit test suite in the cloud.
  *
  * The test is kept here for 1/ local development and 2/ in preparation for future
- * E2E tests running in the cloud CI.
+ * E2E tests running in the cloud CI. Once the E2E test structure is merged we
+ * will move this across.
  */
 @Disabled
 public class DynamoDbProviderE2ETest {
@@ -43,7 +44,7 @@ public void TestGetValue() {
         // Arrange
         HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();
         testItem.put("id", AttributeValue.fromS("test_param"));
-        testItem.put("val", AttributeValue.fromS("the_value_is_hello!"));
+        testItem.put("value", AttributeValue.fromS("the_value_is_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
                         .tableName(ParamsTestTable)
                         .item(testItem)
@@ -64,7 +65,7 @@ public void TestGetValues() {
         HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();
         testItem.put("id", AttributeValue.fromS("test_param"));
         testItem.put("sk", AttributeValue.fromS("test_param_part_1"));
-        testItem.put("val", AttributeValue.fromS("the_value_is_hello!"));
+        testItem.put("value", AttributeValue.fromS("the_value_is_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
                 .tableName(MultiparamsTestTable)
                 .item(testItem)
@@ -73,7 +74,7 @@ public void TestGetValues() {
         HashMap<String, AttributeValue> testItem2 = new HashMap<String, AttributeValue>();
         testItem2.put("id", AttributeValue.fromS("test_param"));
         testItem2.put("sk", AttributeValue.fromS("test_param_part_2"));
-        testItem2.put("val", AttributeValue.fromS("the_value_is_still_hello!"));
+        testItem2.put("value", AttributeValue.fromS("the_value_is_still_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
                 .tableName(MultiparamsTestTable)
                 .item(testItem2)

powertools-parameters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderTest.java

@@ -49,7 +49,7 @@ public void getValue() {
         String expectedValue = "Value1";
         HashMap<String, AttributeValue> responseData = new HashMap<String, AttributeValue>();
         responseData.put("id", AttributeValue.fromS(key));
-        responseData.put("val", AttributeValue.fromS(expectedValue));
+        responseData.put("value", AttributeValue.fromS(expectedValue));
         GetItemResponse response = GetItemResponse.builder()
                 .item(responseData)
                 .build();
@@ -85,7 +85,7 @@ public void getValueWithMalformedRowThrows() {
         String key = "Key1";
         HashMap<String, AttributeValue> responseData = new HashMap<String, AttributeValue>();
         responseData.put("id", AttributeValue.fromS(key));
-        responseData.put("not-val", AttributeValue.fromS("something"));
+        responseData.put("not-value", AttributeValue.fromS("something"));
         Mockito.when(client.getItem(getItemValueCaptor.capture())).thenReturn(GetItemResponse.builder()
                 .item(responseData)
                 .build());
@@ -108,11 +108,11 @@ public void getValues() {
         HashMap<String, AttributeValue> item1 = new HashMap<String, AttributeValue>();
         item1.put("id", AttributeValue.fromS(key));
         item1.put("sk", AttributeValue.fromS(subkey1));
-        item1.put("val", AttributeValue.fromS(val1));
+        item1.put("value", AttributeValue.fromS(val1));
         HashMap<String, AttributeValue> item2 = new HashMap<String, AttributeValue>();
         item2.put("id", AttributeValue.fromS(key));
         item2.put("sk", AttributeValue.fromS(subkey2));
-        item2.put("val", AttributeValue.fromS(val2));
+        item2.put("value", AttributeValue.fromS(val2));
         QueryResponse response = QueryResponse.builder()
                 .items(item1, item2)
                 .build();
@@ -150,7 +150,7 @@ public void getValuesWithMalformedRowThrows() {
         HashMap<String, AttributeValue> item1 = new HashMap<String, AttributeValue>();
         item1.put("id", AttributeValue.fromS(key));
         item1.put("sk", AttributeValue.fromS("some-subkey"));
-        item1.put("notVal", AttributeValue.fromS("somevalue"));
+        item1.put("not-value", AttributeValue.fromS("somevalue"));
         QueryResponse response = QueryResponse.builder()
                 .items(item1)
                 .build();