chore(unit-test): rename, reformat, fix typos as suggested from code review

Co-authored-by: Jérôme Van Der Linden <[email protected]>

Author: eldimi

powertools-core/src/test/java/software/amazon/lambda/powertools/core/internal/LambdaHandlerProcessorTest.java

@@ -80,7 +80,7 @@ void placedOnRequestHandler_shouldInvalidateOnWrongTypeOfArgs() {
 
         boolean isPlacedOnRequestHandler = LambdaHandlerProcessor.placedOnRequestHandler(pjpMock);
 
-        assertFalse(isPlacedOnRequestHandler);
+        assertThat(isPlacedOnRequestHandler).isFalse();
     }
 
     @Test
@@ -104,7 +104,7 @@ void placedOnStreamHandler_shouldInvalidateOnWrongTypeOfArgs() {
     }
 
     @Test
-    void placedOStreamHandler_shouldInvalidateOnTypeOfArgsOneValid() {
+    void placedOnStreamHandler_shouldInvalidateOnTypeOfArgsOneValid() {
         Object[] args = {mock(InputStream.class), new Object(), new Object()};
         ProceedingJoinPoint pjpMock = mockRequestHandlerPjp(RequestStreamHandler.class, args);
 
@@ -114,7 +114,7 @@ void placedOStreamHandler_shouldInvalidateOnTypeOfArgsOneValid() {
     }
 
     @Test
-    void placedOStreamHandler_shouldInvalidateOnTypeOfArgsSomeValid() {
+    void placedOnStreamHandler_shouldInvalidateOnTypeOfArgsSomeValid() {
         Object[] args = {mock(InputStream.class), mock(OutputStream.class), new Object()};
         ProceedingJoinPoint pjpMock = mockRequestHandlerPjp(RequestStreamHandler.class, args);
 
@@ -132,7 +132,7 @@ void getXrayTraceId_present() {
             Optional xRayTraceId = LambdaHandlerProcessor.getXrayTraceId();
 
             assertTrue(xRayTraceId.isPresent());
-            assertEquals(traceID.split(";")[0].replace(LambdaConstants.ROOT_EQUALS, ""), xRayTraceId.get());
+            assertThat(traceID.split(";")[0].replace(LambdaConstants.ROOT_EQUALS, "")).isEqualTo(xRayTraceId.get());
         }
     }
 
@@ -154,7 +154,7 @@ void extractContext_fromRequestHandler() {
 
         Context context = LambdaHandlerProcessor.extractContext(pjpMock);
 
-        assertNotNull(context);
+        assertThat(context).isNotNull();
     }
 
     @Test

powertools-logging/src/test/java/software/amazon/lambda/powertools/logging/handlers/PowerLogToolEnabledWithClearState.java

@@ -22,7 +22,7 @@
 
 public class PowerLogToolEnabledWithClearState implements RequestHandler<Object, Object> {
     public static int COUNT = 1;
-    private final Logger LOG = LogManager.getLogger(PowerLogToolEnabledWithClearState.class);
+    private static final Logger LOG = LogManager.getLogger(PowerLogToolEnabledWithClearState.class);
 
     @Override
     @Logging(clearState = true)

powertools-logging/src/test/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspectTest.java

@@ -276,7 +276,7 @@ void shouldLogCorrelationIdOnALBEvent(ApplicationLoadBalancerRequestEvent event)
     void shouldLogCorrelationIdOnStreamHandler() throws IOException {
         RequestStreamHandler handler = new PowerLogToolEventBridgeCorrelationId();
         String eventId = "3";
-        String event = "{\"id\":" + eventId + "}";
+        String event = "{\"id\":" + eventId + "}"; // CorrelationIdPathConstants.EVENT_BRIDGE
         ByteArrayInputStream inputStream = new ByteArrayInputStream(event.getBytes());
         handler.handleRequest(inputStream, new ByteArrayOutputStream(), context);
 

powertools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/ParamManager.java

@@ -164,7 +164,7 @@ public static TransformationManager getTransformationManager() {
         return transformationManager;
     }
 
-    protected static <T extends BaseProvider> T createProvider(Class<T> providerClass) {
+   static <T extends BaseProvider> T createProvider(Class<T> providerClass) {
         try {
             Constructor<T> constructor = providerClass.getDeclaredConstructor(CacheManager.class);
             T provider = constructor.newInstance(cacheManager);

powertools-parameters/src/test/java/software/amazon/lambda/powertools/parameters/AppConfigProviderTest.java

@@ -23,10 +23,13 @@ public class AppConfigProviderTest {
     private final String environmentName = "test";
     private final String applicationName = "fakeApp";
     private final String defaultTestKey = "key1";
+    
     @Mock
     AppConfigDataClient client;
+    
     @Captor
     ArgumentCaptor<StartConfigurationSessionRequest> startSessionRequestCaptor;
+    
     @Captor
     ArgumentCaptor<GetLatestConfigurationRequest> getLatestConfigurationRequestCaptor;
     private AppConfigProvider provider;

powertools-parameters/src/test/java/software/amazon/lambda/powertools/parameters/ParamManagerTest.java

@@ -55,7 +55,7 @@ public void testCreateProvider() {
     }
 
     @Test
-    public void testCreateProvider_throwsException() {
+    public void testCreateUninstanciableProvider_throwsException() {
 
         // Act & Assert
         assertThatRuntimeException().isThrownBy(() -> ParamManager.createProvider(BaseProvider.class));

powertools-parameters/src/test/java/software/amazon/lambda/powertools/parameters/transform/TransformationManagerTest.java

@@ -28,11 +28,10 @@ public class TransformationManagerTest {
 
     TransformationManager manager;
 
-    Class<BasicTransformer> transformer;
+    Class<BasicTransformer> basicTransformer = BasicTransformer.class;
 
     @BeforeEach
     public void setup() {
-        transformer = BasicTransformer.class;
         manager = new TransformationManager();
     }
 
@@ -63,8 +62,8 @@ public void performBasicTransformation_notBasicTransformer_shouldThrowException(
     }
 
     @Test
-    public void performBasicTransformation_throwsTransformationException() {
-        manager.setTransformer(transformer);
+    public void performBasicTransformation_abstractTransformer_throwsTransformationException() {
+        manager.setTransformer(basicTransformer);
 
         assertThatExceptionOfType(TransformationException.class)
                 .isThrownBy(() -> manager.performBasicTransformation("value"));
@@ -97,7 +96,7 @@ public void performComplexTransformation_shouldPerformTransformation() {
 
     @Test
     public void performComplexTransformation_throwsTransformationException() {
-        manager.setTransformer(transformer);
+        manager.setTransformer(basicTransformer);
 
         assertThatExceptionOfType(TransformationException.class)
                 .isThrownBy(() -> manager.performComplexTransformation("value", ObjectToDeserialize.class));

powertools-serialization/src/test/java/software/amazon/lambda/powertools/utilities/jmespath/Base64GZipFunctionTest.java

@@ -48,7 +48,7 @@ public void testPowertoolsGzip() throws IOException {
     }
 
     @Test
-    public void testPowertoolsGdzipEmptyJsonAttribute() throws IOException {
+    public void testPowertoolsGzipEmptyJsonAttribute() throws IOException {
         JsonNode event = JsonConfig.get().getObjectMapper().readTree(this.getClass().getResourceAsStream("/custom_event_gzip.json"));
         Expression<JsonNode> expression = JsonConfig.get().getJmesPath().compile("basket.powertools_base64_gzip('')");
         JsonNode result = expression.search(event);
@@ -57,7 +57,7 @@ public void testPowertoolsGdzipEmptyJsonAttribute() throws IOException {
     }
 
     @Test
-    public void testPowertoolsGdzipNotCompressedJsonAttribute() throws IOException {
+    public void testPowertoolsGzipNotCompressedJsonAttribute() throws IOException {
         JsonNode event = JsonConfig.get().getObjectMapper().readTree(this.getClass().getResourceAsStream("/custom_event_gzip.json"));
         Expression<JsonNode> expression = JsonConfig.get().getJmesPath().compile("basket.powertools_base64_gzip(encodedString)");
         JsonNode result = expression.search(event);