Skip to content

Commit 3144d03

Browse files
author
Pankaj Agrawal
committed
chore: remove redudant use of setting defautl dimension
1 parent 3670461 commit 3144d03

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static void defaultDimensionSet(final DimensionSet dimensionSet) {
6060
requireNonNull(dimensionSet, "Null dimension set not allowed");
6161

6262
if(dimensionSet.getDimensionKeys().size() > 0) {
63-
MetricsUtils.defaultDimensions = new DimensionSet[]{dimensionSet};
63+
defaultDimensions(dimensionSet);
6464
}
6565
}
6666

@@ -120,7 +120,7 @@ public static void withSingleMetric(final String name,
120120
}
121121
}
122122

123-
public static DimensionSet[] defaultDimensions() {
123+
public static DimensionSet[] getDefaultDimensions() {
124124
return defaultDimensions;
125125
}
126126

@@ -152,7 +152,6 @@ private static MetricsLogger logger() {
152152
MetricsContext metricsContext = new MetricsContext();
153153

154154
if (hasDefaultDimension()) {
155-
metricsContext.setDefaultDimensions(new DimensionSet());
156155
metricsContext.setDimensions(defaultDimensions);
157156
}
158157

powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/internal/LambdaMetricsAspect.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,9 @@ public static void refreshMetricsContext(Metrics metrics) {
125125
f.setAccessible(true);
126126
MetricsContext context = new MetricsContext();
127127

128-
DimensionSet[] defaultDimensions = hasDefaultDimension() ? MetricsUtils.defaultDimensions()
128+
DimensionSet[] defaultDimensions = hasDefaultDimension() ? MetricsUtils.getDefaultDimensions()
129129
: new DimensionSet[]{DimensionSet.of("Service", service(metrics))};
130130

131-
context.setDefaultDimensions(new DimensionSet());
132131
context.setDimensions(defaultDimensions);
133132

134133
f.set(metricsLogger(), context);

0 commit comments

Comments
 (0)