fixing sonar issues

Author: hjgraca

libraries/src/AWS.Lambda.Powertools.Tracing/Internal/TracingAspect.cs

@@ -33,17 +33,17 @@ public class TracingAspect
     /// <summary>
     ///     The Powertools for AWS Lambda (.NET) configurations
     /// </summary>
-    private IPowertoolsConfigurations _powertoolsConfigurations;
+    private readonly IPowertoolsConfigurations _powertoolsConfigurations;
 
     /// <summary>
     ///     X-Ray Recorder
     /// </summary>
-    private IXRayRecorder _xRayRecorder;
+    private readonly IXRayRecorder _xRayRecorder;
 
     /// <summary>
     ///     If true, then is cold start
     /// </summary>
-    private static bool _isColdStart;
+    private static bool _isColdStart = true;
 
     /// <summary>
     ///     If true, capture annotations
@@ -70,7 +70,6 @@ public class TracingAspect
     /// </summary>
     public TracingAspect()
     {
-        _isColdStart = true;
         _xRayRecorder = XRayRecorder.Instance;
         _powertoolsConfigurations = PowertoolsConfigurations.Instance;
     }
@@ -91,12 +90,8 @@ public TracingAspect()
     /// <returns></returns>
     [Advice(Kind.Around)]
     public object Around(
-        [Argument(Source.Instance)] object instance,
         [Argument(Source.Name)] string name,
         [Argument(Source.Arguments)] object[] args,
-        [Argument(Source.Type)] Type hostType,
-        [Argument(Source.Metadata)] MethodBase method,
-        [Argument(Source.ReturnType)] Type returnType,
         [Argument(Source.Target)] Func<object[], object> target,
         [Argument(Source.Triggers)] Attribute[] triggers)
     {

libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/Handlers/HandlerTests.cs

@@ -68,7 +68,7 @@ public async Task Full_Example()
         Assert.True(handleSegment.IsSubsegmentsAdded);
 
         Assert.Equal("POWERTOOLS", handleSegment.Annotations["Service"]);
-        Assert.Equal(true, handleSegment.Annotations["ColdStart"]);
+        Assert.True((bool)handleSegment.Annotations["ColdStart"]);
         Assert.Equal("value", handleSegment.Annotations["annotation"]);
         Assert.Equal("## Handle", handleSegment.Name);
 

libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/TracingAttributeTest.cs

@@ -61,15 +61,15 @@ public void OnEntry_WhenFirstCall_CapturesColdStart()
             Assert.Single(segmentCold.Subsegments);
             Assert.True(subSegmentCold.IsAnnotationsAdded);
             Assert.Equal(2, subSegmentCold.Annotations.Count());
-            Assert.Equal(true, subSegmentCold.Annotations.Single(x => x.Key == "ColdStart").Value);
+            Assert.True((bool)subSegmentCold.Annotations.Single(x => x.Key == "ColdStart").Value);
             Assert.Equal("POWERTOOLS", subSegmentCold.Annotations.Single(x => x.Key == "Service").Value);
 
             // Warm
             Assert.True(segmentWarm.IsSubsegmentsAdded);
             Assert.Single(segmentWarm.Subsegments);
             Assert.True(subSegmentWarm.IsAnnotationsAdded);
             Assert.Equal(2, subSegmentWarm.Annotations.Count());
-            Assert.Equal(false, subSegmentWarm.Annotations.Single(x => x.Key == "ColdStart").Value);
+            Assert.False((bool)subSegmentWarm.Annotations.Single(x => x.Key == "ColdStart").Value);
             Assert.Equal("POWERTOOLS", subSegmentWarm.Annotations.Single(x => x.Key == "Service").Value);
         }
 
@@ -98,14 +98,14 @@ public void OnEntry_WhenFirstCall_And_Service_Not_Set_CapturesColdStart()
             Assert.Single(segmentCold.Subsegments);
             Assert.True(subSegmentCold.IsAnnotationsAdded);
             Assert.Single(subSegmentCold.Annotations);
-            Assert.Equal(true, subSegmentCold.Annotations.Single(x => x.Key == "ColdStart").Value);
+            Assert.True((bool)subSegmentCold.Annotations.Single(x => x.Key == "ColdStart").Value);
 
             // Warm
             Assert.True(segmentWarm.IsSubsegmentsAdded);
             Assert.Single(segmentWarm.Subsegments);
             Assert.True(subSegmentWarm.IsAnnotationsAdded);
             Assert.Single(subSegmentWarm.Annotations);
-            Assert.Equal(false, subSegmentWarm.Annotations.Single(x => x.Key == "ColdStart").Value);
+            Assert.False((bool)subSegmentWarm.Annotations.Single(x => x.Key == "ColdStart").Value);
         }
 
         public void Dispose()