Skip to content

Commit eb83084

Browse files
authored
Fix Cidr type in AWS::EC2::IPAMPool (#4101)
1 parent 46f4cf9 commit eb83084

File tree

14 files changed

+65
-8
lines changed

14 files changed

+65
-8
lines changed

scripts/update_schemas_format.py

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def _descend(instance: Any, keywords: Sequence[str]) -> Iterator[deque[str]]:
3939
def _create_cidr_patch(type_name: str, ref: str, resolver: RefResolver, format: str):
4040
if type_name in [
4141
"AWS::SecurityHub::Insight",
42+
"AWS::EC2::IPAMPool",
4243
]:
4344
return []
4445

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
[
2+
{
3+
"op": "add",
4+
"path": "/definitions/PhysicalConnectionRequirements/properties/SecurityGroupIdList/format",
5+
"value": "AWS::EC2::SecurityGroup.Ids"
6+
},
7+
{
8+
"op": "add",
9+
"path": "/definitions/PhysicalConnectionRequirements/properties/SecurityGroupIdList/items/format",
10+
"value": "AWS::EC2::SecurityGroup.Id"
11+
},
12+
{
13+
"op": "add",
14+
"path": "/definitions/PhysicalConnectionRequirements/properties/SubnetId/format",
15+
"value": "AWS::EC2::Subnet.Id"
16+
}
17+
]

src/cfnlint/data/schemas/patches/extensions/all/aws_ec2_ipampool/format.json

-7
This file was deleted.

src/cfnlint/data/schemas/patches/extensions/all/aws_ec2_routeserverassociation/__init__.py

Whitespace-only changes.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[
2+
{
3+
"op": "add",
4+
"path": "/properties/VpcId/format",
5+
"value": "AWS::EC2::VPC.Id"
6+
}
7+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
[
2+
{
3+
"op": "add",
4+
"path": "/properties/SubnetId/format",
5+
"value": "AWS::EC2::Subnet.Id"
6+
},
7+
{
8+
"op": "add",
9+
"path": "/properties/VpcId/format",
10+
"value": "AWS::EC2::VPC.Id"
11+
}
12+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
[
2+
{
3+
"op": "add",
4+
"path": "/properties/SubnetId/format",
5+
"value": "AWS::EC2::Subnet.Id"
6+
},
7+
{
8+
"op": "add",
9+
"path": "/properties/VpcId/format",
10+
"value": "AWS::EC2::VPC.Id"
11+
}
12+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[
2+
{
3+
"op": "add",
4+
"path": "/definitions/KendraSourceDetail/properties/RoleArn/format",
5+
"value": "AWS::IAM::Role.Arn"
6+
}
7+
]

src/cfnlint/data/schemas/providers/us_east_1/aws-datazone-connection.json

+3
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,10 @@
431431
"type": "string"
432432
},
433433
"SecurityGroupIdList": {
434+
"format": "AWS::EC2::SecurityGroup.Ids",
434435
"insertionOrder": false,
435436
"items": {
437+
"format": "AWS::EC2::SecurityGroup.Id",
436438
"maxLength": 255,
437439
"minLength": 1,
438440
"type": "string"
@@ -442,6 +444,7 @@
442444
"type": "array"
443445
},
444446
"SubnetId": {
447+
"format": "AWS::EC2::Subnet.Id",
445448
"maxLength": 32,
446449
"pattern": "^subnet-[a-z0-9]+$",
447450
"type": "string"

src/cfnlint/data/schemas/providers/us_east_1/aws-ec2-ipampool.json

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
],
1313
"definitions": {
1414
"Cidr": {
15-
"format": "ipv4-network",
1615
"type": "string"
1716
},
1817
"ProvisionedCidr": {

src/cfnlint/data/schemas/providers/us_east_1/aws-ec2-routeserverassociation.json

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"type": "string"
1515
},
1616
"VpcId": {
17+
"format": "AWS::EC2::VPC.Id",
1718
"type": "string"
1819
}
1920
},

src/cfnlint/data/schemas/providers/us_east_1/aws-ec2-routeserverendpoint.json

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
"type": "string"
4747
},
4848
"SubnetId": {
49+
"format": "AWS::EC2::Subnet.Id",
4950
"type": "string"
5051
},
5152
"Tags": {
@@ -57,6 +58,7 @@
5758
"uniqueItems": false
5859
},
5960
"VpcId": {
61+
"format": "AWS::EC2::VPC.Id",
6062
"type": "string"
6163
}
6264
},

src/cfnlint/data/schemas/providers/us_east_1/aws-ec2-routeserverpeer.json

+2
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
"type": "string"
7676
},
7777
"SubnetId": {
78+
"format": "AWS::EC2::Subnet.Id",
7879
"type": "string"
7980
},
8081
"Tags": {
@@ -86,6 +87,7 @@
8687
"uniqueItems": false
8788
},
8889
"VpcId": {
90+
"format": "AWS::EC2::VPC.Id",
8991
"type": "string"
9092
}
9193
},

src/cfnlint/data/schemas/providers/us_east_1/aws-iotsitewise-dataset.json

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"type": "string"
3737
},
3838
"RoleArn": {
39+
"format": "AWS::IAM::Role.Arn",
3940
"maxLength": 1600,
4041
"minLength": 1,
4142
"pattern": "^arn:aws(-cn|-us-gov)?:[a-zA-Z0-9-:\\/_\\.]+$",

0 commit comments

Comments
 (0)