adding isolated regions (#4103)

* adding isolated regions

---------

Co-authored-by: Vandita Patidar <[email protected]>
Co-authored-by: Kevin DeJong <[email protected]>

Author: 3 people

src/cfnlint/data/schemas/providers/eu_isoe_west_1/__init__.py

@@ -115,6 +115,13 @@
     "us-gov-west-1": ["us-gov-west-1a", "us-gov-west-1b", "us-gov-west-1c"],
     "us-west-1": ["us-west-1a", "us-west-1c"],
     "us-west-2": ["us-west-2a", "us-west-2b", "us-west-2c", "us-west-2d"],
+    # Isolated regions
+    "us-iso-east-1": ["us-iso-east-1a", "us-iso-east-1b", "us-iso-east-1c"],
+    "us-iso-west-1": ["us-iso-west-1a", "us-iso-west-1b", "us-iso-west-1c"],
+    "us-isob-east-1": ["us-isob-east-1a", "us-isob-east-1b", "us-isob-east-1c"],
+    "us-isof-east-1": ["us-isof-east-1a", "us-isof-east-1b", "us-isof-east-1c"],
+    "us-isof-south-1": ["us-isof-south-1a", "us-isof-south-1b", "us-isof-south-1c"],
+    "eu-isoe-west-1": ["eu-isoe-west-1a", "eu-isoe-west-1b", "eu-isoe-west-1c"],
 }
 
 REGIONS = list(AVAILABILITY_ZONES.keys())

src/cfnlint/data/schemas/providers/us_iso_east_1/__init__.py

@@ -282,6 +282,32 @@ def _update_provider_schema(self, region: str, force: bool = False) -> None:
 
         multiprocessing_logger.debug("Downloading template %s into %s", url, directory)
 
+        if "iso" in region:
+            all_types = ["AWS::CDK::Metadata", "Module"]
+            cached = ["Module"]
+            filenames = [
+                f
+                for f in os.listdir(directory_pr)
+                if os.path.isfile(os.path.join(directory_pr, f)) and f != "__init__.py"
+            ]
+            for filename in filenames:
+                with open(f"{directory_pr}{filename}", "r+", encoding="utf-8") as fh:
+                    spec = json.load(fh)
+                    all_types.append(spec["typeName"])
+                cached.append(filename)
+
+            with open(f"{directory}__init__.py", encoding="utf-8", mode="w") as f:
+                f.write("from __future__ import annotations\n\n")
+                f.write("# pylint: disable=too-many-lines\ntypes: list[str] = [\n")
+                for rt in sorted(all_types):
+                    f.write(f'    "{rt}",\n')
+                f.write(
+                    "]\n\n# pylint: disable=too-many-lines\ncached: list[str] = [\n"
+                )
+                for cache_file in sorted(cached):
+                    f.write(f'    "{cache_file}",\n')
+                f.write("]\n")
+
         # Check to see if we already have the latest version, and if so stop
         if not (url_has_newer_version(url) or force):
             return

src/cfnlint/data/schemas/providers/us_iso_west_1/__init__.py

@@ -162,6 +162,55 @@ def test_update_resource_spec_cache(
             mock_filecmp_cmp.assert_called_once()
             mock_os_remove.assert_called_once()
 
+    @patch("cfnlint.schema.manager.json.dump")
+    @patch("cfnlint.schema.manager.REGIONS", ["us-east-1"])
+    @patch("cfnlint.schema.manager.os.listdir")
+    @patch("cfnlint.schema.manager.os.path.isfile")
+    def test_update_resource_for_iso_region(
+        self,
+        mock_os_path_isfile,
+        mock_os_listdir,
+        mock_json_dump,
+    ):
+        """Success update resource spec with cache"""
+        schema = self.schemas["aws-lambda-codesigningconfig"]
+
+        mock_os_listdir.return_value = [
+            "aws_lambda_codesigningconfig.json",
+            "__init__.py",
+        ]
+        mock_os_path_isfile.side_effect = [True, True, True, True]
+        builtin_module_name = "builtins"
+
+        with patch(
+            "{}.open".format(builtin_module_name), mock_open(read_data=schema)
+        ) as mock_builtin_open:
+            self.manager._update_provider_schema("us-iso-west-1", False)
+            mock_json_dump.assert_not_called()
+            mock_os_listdir.assert_has_calls(
+                [
+                    call(f"{self.manager._root.path_relative}/us_east_1/"),
+                ]
+            )
+            mock_builtin_open.assert_has_calls(
+                [
+                    call().__enter__(),
+                    call().write("from __future__ import annotations\n\n"),
+                    call().write(
+                        "# pylint: disable=too-many-lines\ntypes: list[str] = [\n"
+                    ),
+                    call().write('    "AWS::CDK::Metadata",\n'),
+                    call().write('    "AWS::Lambda::CodeSigningConfig",\n'),
+                    call().write('    "Module",\n'),
+                    call().write(
+                        "]\n\n# pylint: disable=too-many-lines\ncached: list[str] = [\n"
+                    ),
+                    call().write('    "Module",\n'),
+                    call().write('    "aws_lambda_codesigningconfig.json",\n'),
+                    call().write("]\n"),
+                ]
+            )
+
     @patch("cfnlint.schema.manager.url_has_newer_version")
     @patch("cfnlint.schema.manager.get_url_retrieve")
     @patch("cfnlint.schema.manager.json.dump")
@@ -272,6 +321,15 @@ def test_removed_types(self):
         with self.assertRaises(ResourceNotFoundError):
             self.manager.get_resource_schema(region, rt)
 
+    def test_getting_us_east_1_schema_in_iso(self):
+        rt = "AWS::EC2::VPC"
+
+        schema_us_east_1 = self.manager.get_resource_schema("us-east-1", rt)
+        schema_iso = self.manager.get_resource_schema("us-iso-east-1", rt)
+
+        self.assertDictEqual(schema_us_east_1.schema, schema_iso.schema)
+        self.assertTrue(schema_iso.is_cached)
+
     def test_type_normalization(self):
 
         rt = "MyCompany::MODULE"