Deprecate py3.8 (#3975)

* Deprecate py3.8

Author: kddejong

.github/workflows/ci-branch.yaml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python: [ "3.8", "3.9", "3.10", "3.11", "3.12", "3.13" ]
+        python: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/ci-pr.yaml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
+        python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
 
     steps:
       - uses: actions/checkout@v4

CONTRIBUTING.md

@@ -51,11 +51,9 @@ $ pip install tox
 $ tox
 
 # Run a specific test suite
-$ tox -e py37 # Run all unit tests against Python 3.7
+$ tox -e py39 # Run all unit tests against Python 3.9
 ```
 Tox test suites available:
-* **py37**: Unit tests (Python 3.7)
-* **py38**: Unit tests (Python 3.8)
 * **py39**: Unit tests (Python 3.9)
 * **py310**: Unit tests (Python 3.10)
 * **py311**: Unit tests (Python 3.11)

README.md

@@ -40,7 +40,7 @@ _To get information about the [SAM Transformation](https://docs.aws.amazon.com/A
 
 ## Install
 
-Python 3.8+ is supported.
+Python 3.9+ is supported.
 
 ### Pip
 

pyproject.toml

@@ -14,7 +14,7 @@ readme = {file = ["README.md"], content-type = "text/markdown"}
 [project]
 name = "cfn-lint"
 description = "Checks CloudFormation templates for practices and behaviour that could potentially be improved"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = {text = "MIT no attribution"}
 keywords = ["aws", "cloudformation", "lint"]
 authors = [
@@ -28,7 +28,6 @@ classifiers = [
     "Natural Language :: English",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

src/cfnlint/helpers.py

@@ -17,7 +17,6 @@
 import json
 import logging
 import os
-import sys
 from io import BytesIO
 from typing import Any, Sequence
 from urllib.request import Request, urlopen, urlretrieve
@@ -517,14 +516,11 @@ def load_resource(package, filename="us-east-1.json"):
     :param filename: filename to load
     :return: Json output of the resource laoded
     """
-    if sys.version_info >= (3, 9):
-        return json.loads(
-            pkg_resources.files(package)  # pylint: disable=no-member
-            .joinpath(filename)
-            .read_text(encoding="utf-8")
-        )
-    # pylint: disable=W4902
-    return json.loads(pkg_resources.read_text(package, filename, encoding="utf-8"))
+    return json.loads(
+        pkg_resources.files(package)  # pylint: disable=no-member
+        .joinpath(filename)
+        .read_text(encoding="utf-8")
+    )
 
 
 def is_custom_resource(resource_type):

src/cfnlint/match.py

@@ -6,7 +6,6 @@
 from __future__ import annotations
 
 import hashlib
-import sys
 import uuid
 from dataclasses import InitVar, dataclass, field
 from pathlib import Path
@@ -54,12 +53,9 @@ class Match:
     rulematch_obj: InitVar[RuleMatch | None] = None
 
     def __post_init__(self, rulematch_obj):
-        if sys.version_info.major == 3 and sys.version_info.minor > 8:
-            hex_string = hashlib.md5(
-                f"{self}".encode("UTF-8"), usedforsecurity=False
-            ).hexdigest()
-        else:
-            hex_string = hashlib.md5(f"{self}".encode("UTF-8")).hexdigest()
+        hex_string = hashlib.md5(
+            f"{self}".encode("UTF-8"), usedforsecurity=False
+        ).hexdigest()
         super().__setattr__("id", str(uuid.UUID(hex=hex_string)))
 
         if rulematch_obj:

src/cfnlint/template/transforms/_language_extensions.py

@@ -10,7 +10,6 @@
 import logging
 import random
 import string
-import sys
 from copy import deepcopy
 from typing import Any, Iterator, Mapping, MutableMapping, Tuple
 
@@ -207,16 +206,11 @@ def _replace_string_params(
         new_s = deepcopy(s)
         for k, v in params.items():
             if isinstance(v, dict):
-                if sys.version_info.major == 3 and sys.version_info.minor > 8:
-                    v = (
-                        hashlib.md5(
-                            json.dumps(v).encode("utf-8"), usedforsecurity=False
-                        )
-                        .digest()
-                        .hex()[0:4]
-                    )
-                else:
-                    v = hashlib.md5(json.dumps(v).encode("utf-8")).digest().hex()[0:4]
+                v = (
+                    hashlib.md5(json.dumps(v).encode("utf-8"), usedforsecurity=False)
+                    .digest()
+                    .hex()[0:4]
+                )
             new_s = re.sub(rf"\$\{{{k}\}}", v, new_s)
             new_s = re.sub(rf"\&\{{{k}\}}", re.sub("[^0-9a-zA-Z]+", "", v), new_s)
 

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py{38,39,310,311,312,313},style
+envlist = py{39,310,311,312,313},style
 isolated_build = true
 
 [testenv]