Skip to content

Commit 9d68e60

Browse files
authored
Allow 5.7/8.0 for DB Engine Version (#3796)
1 parent f17aa12 commit 9d68e60

File tree

3 files changed

+23
-8
lines changed

3 files changed

+23
-8
lines changed

scripts/update_schemas_from_aws_api.py

+19-8
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,15 @@ def write_db_cluster(results):
7474
for engine in engines:
7575
if not results.get(engine):
7676
continue
77+
78+
engine_versions = sorted(results.get(engine))
79+
if engine == "aurora-mysql":
80+
for engine_version in engine_versions.copy():
81+
sub_engine_version = ".".join(engine_version.split(".")[0:2])
82+
if sub_engine_version not in engine_versions:
83+
engine_versions.append(sub_engine_version)
84+
engine_versions = sorted(engine_versions)
85+
7786
schema["allOf"].append(
7887
{
7988
"if": {
@@ -85,11 +94,7 @@ def write_db_cluster(results):
8594
},
8695
"required": ["Engine", "EngineVersion"],
8796
},
88-
"then": {
89-
"properties": {
90-
"EngineVersion": {"enum": sorted(results.get(engine))}
91-
}
92-
},
97+
"then": {"properties": {"EngineVersion": {"enum": engine_versions}}},
9398
}
9499
)
95100

@@ -145,6 +150,14 @@ def write_db_instance(results):
145150
for engine in engines:
146151
if not results.get(engine):
147152
continue
153+
154+
engine_versions = sorted(results.get(engine))
155+
if engine == "aurora-mysql":
156+
for engine_version in engine_versions.copy():
157+
sub_engine_version = ".".join(engine_version.split(".")[0:2])
158+
if sub_engine_version not in engine_versions:
159+
engine_versions.append(sub_engine_version)
160+
engine_versions = sorted(engine_versions)
148161
schema["allOf"].append(
149162
{
150163
"if": {
@@ -159,9 +172,7 @@ def write_db_instance(results):
159172
"required": ["Engine", "EngineVersion"],
160173
},
161174
"then": {
162-
"properties": {
163-
"EngineVersion": {"enum": sorted(results.get(engine))}
164-
}
175+
"properties": {"EngineVersion": {"enum": sorted(engine_versions)}}
165176
},
166177
}
167178
)

src/cfnlint/data/schemas/extensions/aws_rds_dbcluster/engine_version.json

+2
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"properties": {
5050
"EngineVersion": {
5151
"enum": [
52+
"5.7",
5253
"5.7.mysql_aurora.2.11.1",
5354
"5.7.mysql_aurora.2.11.2",
5455
"5.7.mysql_aurora.2.11.3",
@@ -61,6 +62,7 @@
6162
"5.7.mysql_aurora.2.12.2",
6263
"5.7.mysql_aurora.2.12.3",
6364
"5.7.mysql_aurora.2.12.4",
65+
"8.0",
6466
"8.0.mysql_aurora.3.04.0",
6567
"8.0.mysql_aurora.3.04.1",
6668
"8.0.mysql_aurora.3.04.2",

src/cfnlint/data/schemas/extensions/aws_rds_dbinstance/engine_version.json

+2
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"properties": {
6666
"EngineVersion": {
6767
"enum": [
68+
"5.7",
6869
"5.7.mysql_aurora.2.11.1",
6970
"5.7.mysql_aurora.2.11.2",
7071
"5.7.mysql_aurora.2.11.3",
@@ -77,6 +78,7 @@
7778
"5.7.mysql_aurora.2.12.2",
7879
"5.7.mysql_aurora.2.12.3",
7980
"5.7.mysql_aurora.2.12.4",
81+
"8.0",
8082
"8.0.mysql_aurora.3.04.0",
8183
"8.0.mysql_aurora.3.04.1",
8284
"8.0.mysql_aurora.3.04.2",

0 commit comments

Comments
 (0)