Test format of json files (#2651)

Author: kddejong

scripts/fix_data_files.py

@@ -0,0 +1,39 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+import fnmatch
+import json
+import os
+from unittest import TestCase
+
+import jsonpatch
+
+import cfnlint
+import cfnlint.core
+from cfnlint.helpers import format_json_string
+
+modules = [
+    "ExtendedSpecs",
+    "AdditionalSpecs",
+    "CfnLintCli",
+    "Serverless",
+]
+
+for module in modules:
+    append_dir = os.path.join(
+        os.path.dirname(cfnlint.__file__),
+        "data",
+        module,
+    )
+    for dirpath, _, filenames in os.walk(append_dir):
+        for filename in fnmatch.filter(filenames, "*.json"):
+            string_content = ""
+            with open(os.path.join(dirpath, filename), encoding="utf8") as input_file:
+                string_content = "".join(input_file.readlines())
+
+            pretty_content = format_json_string(json.loads(string_content))
+            with open(
+                os.path.join(dirpath, filename), encoding="utf8", mode="w"
+            ) as output_file:
+                output_file.write(pretty_content)

scripts/install

@@ -11,7 +11,6 @@ import subprocess
 import sys
 import tarfile
 import tempfile
-
 from contextlib import contextmanager
 
 PACKAGES_DIR = os.path.join(

scripts/make-bundle

@@ -13,14 +13,13 @@ ecosystem.
 
 """
 import os
-import sys
-import subprocess
 import shutil
+import subprocess
+import sys
 import tempfile
 import zipfile
 from contextlib import contextmanager
 
-
 EXTRA_RUNTIME_DEPS = [
     # Use an up to date virtualenv/pip/setuptools on > 2.6.
     ('virtualenv', '16.7.8'),

scripts/update_serverless_aws_policies.py

@@ -4,26 +4,34 @@
 SPDX-License-Identifier: MIT-0
 """
 
+import json
 import logging
+
 import boto3
-import json
 from samtranslator.translator.managed_policy_translator import ManagedPolicyLoader
-LOGGER = logging.getLogger('cfnlint')
+
+LOGGER = logging.getLogger("cfnlint")
 
 
 def main():
     session = boto3.session.Session()
-    client = session.client('iam', region_name='us-east-1')
+    client = session.client("iam", region_name="us-east-1")
 
     policyLoader = ManagedPolicyLoader(client)
     policyLoader.load()
 
-    filename = 'src/cfnlint/data/Serverless/ManagedPolicies.json'
-    with open(filename, 'w+', encoding='utf-8') as f:
-        json.dump(policyLoader._policy_map, f, indent=1, sort_keys=True, separators=(',', ': '))
+    filename = "src/cfnlint/data/Serverless/ManagedPolicies.json"
+    with open(filename, "w+", encoding="utf-8") as f:
+        json.dump(
+            policyLoader._policy_map,
+            f,
+            indent=1,
+            sort_keys=True,
+            separators=(",", ": "),
+        )
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     try:
         main()
     except (ValueError, TypeError):