Remove rule setting in propertyNames rule (#3365)

* Remove rule setting in propertyNames rule
* Import requests into maintenance job

Author: kddejong

.github/workflows/maintenance-v1.yaml

@@ -20,6 +20,7 @@ jobs:
           latest=`curl "https://pypi.org/pypi/aws-sam-cli/$latest_sam_cli/json" -s | jq -r '.info.requires_dist[] | select(contains("aws-sam-translator"))' | cut -c 21-`
           sed -i -E "s/aws-sam-translator>=[0-9.]+/aws-sam-translator>=$latest/" pyproject.toml
           pip install -e .
+          pip install requests
           rm -rf src/cfnlint/data/DownloadsMetadata/*
           cfn-lint --update-iam-policies
           cfn-lint --update-documentation

src/cfnlint/rules/jsonschema/PropertyNames.py

@@ -66,11 +66,8 @@ def propertyNames(
         )({})
 
         for property in instance:
-            for err in v.descend(
+            yield from v.descend(
                 instance=property,
                 schema=propertyNames,
                 path=property,
-            ):
-                if err.rule is None:
-                    err.rule = self
-                yield err
+            )

test/unit/rules/jsonschema/test_property_names.py

@@ -108,7 +108,7 @@ def __init__(self):
         )
 
         self.assertEqual(len(errs), 1)
-        self.assertEqual(errs[0].rule.id, "AAAAA")
+        self.assertIsNone(errs[0].rule)
 
     def test_rule_not_object(self):
         validator = CfnTemplateValidator({})