Security groups are now supported for network load balancers (#2853)

Author: kkumler

src/cfnlint/rules/resources/elb/Elb.py

@@ -157,25 +157,6 @@ def match_resource_properties(self, resource_properties, _, path, cfn):
         scenarios = cfn.get_object_without_nested_conditions(resource_properties, path)
         for scenario in scenarios:
             properties = scenario.get("Object")
-            if self.get_loadbalancer_type(properties) == "network":
-                if properties.get("SecurityGroups"):
-                    if scenario.get("Scenario"):
-                        scenario_text = " and ".join(
-                            [
-                                f'when condition "{k}" is {v}'
-                                for (k, v) in scenario.get("Scenario").items()
-                            ]
-                        )
-                        message = f'Security groups are not supported for load balancers with type "network" {scenario_text}'
-                        matches.append(RuleMatch(path, message))
-                    else:
-                        path = path + ["SecurityGroups"]
-                        matches.append(
-                            RuleMatch(
-                                path,
-                                'Security groups are not supported for load balancers with type "network"',
-                            )
-                        )
 
             matches.extend(
                 self.check_alb_subnets(properties, path, scenario.get("Scenario"))

test/unit/rules/resources/elb/test_elb.py

@@ -25,7 +25,7 @@ def test_file_positive(self):
     def test_file_negative(self):
         """Test failure"""
         self.helper_file_negative(
-            "test/fixtures/templates/bad/resources/elb/properties.yaml", 8
+            "test/fixtures/templates/bad/resources/elb/properties.yaml", 6
         )
 
     def test_alb_subnets(self):