Allow _ in condition names (#4008)

kddejong · web-flow · commit 3cc4012ac76f · 2025-03-11T09:21:10.000-07:00
* Allow _ in condition names
diff --git a/src/cfnlint/data/schemas/other/conditions/conditions.json b/src/cfnlint/data/schemas/other/conditions/conditions.json
@@ -1,7 +1,7 @@
 {
  "additionalProperties": false,
  "patternProperties": {
-  "^[a-zA-Z0-9&]{1,255}$": {
+  "^[a-zA-Z0-9&_]{1,255}$": {
    "type": "boolean"
   }
  },
diff --git a/test/unit/rules/conditions/test_conditions.py b/test/unit/rules/conditions/test_conditions.py
@@ -32,7 +32,7 @@ def test_condition(self):
                     path=deque(["bar"]),
                     rule=Configuration(),
                     schema_path=deque(
-                        ["patternProperties", "^[a-zA-Z0-9&]{1,255}$", "type"]
+                        ["patternProperties", "^[a-zA-Z0-9&_]{1,255}$", "type"]
                     ),
                     validator="type",
                     validator_value="boolean",

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"additionalProperties": false,`
`3`	`3`	`"patternProperties": {`
`4`		`- "^[a-zA-Z0-9&]{1,255}$": {`
	`4`	`+ "^[a-zA-Z0-9&_]{1,255}$": {`
`5`	`5`	`"type": "boolean"`
`6`	`6`	`}`
`7`	`7`	`},`