V1 Cleanup based on testing of templates repo (#3303)

* Cleanup issues from testing templates repo
* Validate ref values are plausible before resolution
* Support future condition logic in context

Author: kddejong

scripts/update_schemas_format.py

@@ -18,6 +18,7 @@
 from cfnlint.conditions._condition import ConditionNamed
 from cfnlint.conditions._equals import Equal
 from cfnlint.conditions._utils import get_hash
+from cfnlint.helpers import PSEUDOPARAMS
 
 LOGGER = logging.getLogger(__name__)
 
@@ -348,3 +349,61 @@ def build_scenerios_on_region(
         )
         if satisfiable(cnf_test):
             yield False
+
+    def satisfiable(
+        self, conditions: dict[str, bool], parameter_values: dict[str, str]
+    ) -> bool:
+        """Given a list of condition names this function will
+        determine if the conditions are satisfied
+
+        Args:
+            condition_names (List[str]): A list of condition names
+
+        Returns:
+            bool: True if the conditions are satisfied
+        """
+        if not conditions:
+            return True
+
+        cnf = self._cnf.copy()
+        at_least_one_param_found = False
+        for condition_name, opt in conditions.items():
+            for c_equals in self._conditions[condition_name].equals:
+                found_params = {}
+                for param, value in parameter_values.items():
+                    if param in PSEUDOPARAMS:
+                        continue
+
+                    ref_hash = get_hash({"Ref": param})
+                    if ref_hash in c_equals.parameters:
+                        found_params = {ref_hash: value}
+
+                if not found_params:
+                    continue
+
+                at_least_one_param_found = True
+                if c_equals.test(found_params):
+                    cnf.add_prop(Symbol(c_equals.hash))
+                else:
+                    cnf.add_prop(Not(Symbol(c_equals.hash)))
+
+                if opt:
+                    cnf.add_prop(
+                        self._conditions[condition_name].build_true_cnf(
+                            self._solver_params
+                        )
+                    )
+                else:
+                    cnf.add_prop(
+                        self._conditions[condition_name].build_false_cnf(
+                            self._solver_params
+                        )
+                    )
+
+        if at_least_one_param_found is False:
+            return True
+
+        satisfied = satisfiable(cnf, all_models=False)
+        if satisfied is False:
+            return satisfied
+        return True

src/cfnlint/conditions/conditions.py

@@ -0,0 +1,70 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from __future__ import annotations
+
+from dataclasses import dataclass, field
+from typing import Any
+
+
+@dataclass(frozen=True)
+class Condition:
+    instance: Any = field(init=True)
+    status: bool | None = field(init=True, default=None)
+
+    def evolve(self, status: bool | None) -> "Condition":
+        cls = self.__class__
+
+        if self.status is not None:
+            if status != self.status:
+                raise ValueError("Resetting status to condition")
+
+        return cls(
+            instance=self.instance,
+            status=status,
+        )
+
+
+@dataclass(frozen=True)
+class Conditions:
+    # Template level condition management
+    conditions: dict[str, Condition] = field(init=True, default_factory=dict)
+
+    @classmethod
+    def create_from_instance(cls, conditions: dict[str, Any]) -> "Conditions":
+        obj = {}
+        if not isinstance(conditions, dict):
+            raise ValueError("Conditions must be a object")
+        for k, v in conditions.items():
+            try:
+                obj[k] = Condition(v)
+            except ValueError:
+                pass
+
+        return cls(conditions=obj)
+
+    def evolve(self, status: dict[str, bool]) -> "Conditions":
+        cls = self.__class__
+
+        conditions: dict[str, Condition] = {}
+        for condition, value in self.conditions.items():
+            s = status.get(condition, value.status)
+            try:
+                conditions[condition] = value.evolve(status=s)
+            except ValueError as e:
+                raise ValueError(f"Error evolving condition {condition}") from e
+
+        return cls(
+            conditions=conditions,
+        )
+
+    @property
+    def status(self) -> dict[str, bool]:
+        obj = {}
+        for name, c in self.conditions.items():
+            if c.status is not None:
+                obj[name] = c.status
+
+        return obj

src/cfnlint/context/_conditions.py

@@ -8,8 +8,9 @@
 from abc import ABC, abstractmethod
 from collections import deque
 from dataclasses import InitVar, dataclass, field, fields
-from typing import Any, Deque, Dict, Iterator, List, Mapping, Sequence, Set, Tuple
+from typing import Any, Deque, Dict, Iterator, List, Sequence, Set, Tuple
 
+from cfnlint.context._conditions import Conditions
 from cfnlint.helpers import (
     BOOLEAN_STRINGS_TRUE,
     FUNCTIONS,
@@ -136,7 +137,7 @@ class Context:
     # cfn-lint Template class
     parameters: Dict[str, "Parameter"] = field(init=True, default_factory=dict)
     resources: Dict[str, "Resource"] = field(init=True, default_factory=dict)
-    conditions: Dict[str, "Condition"] = field(init=True, default_factory=dict)
+    conditions: Conditions = field(init=True, default_factory=Conditions)
     mappings: Dict[str, "Map"] = field(init=True, default_factory=dict)
 
     strict_types: bool = field(init=True, default=True)
@@ -149,9 +150,6 @@ class Context:
     # and adds in any Refs available from things like Fn::Sub
     ref_values: Dict[str, Any] = field(init=True, default_factory=dict)
 
-    # Resolved conditions for reference
-    resolved_conditions: Mapping[str, bool] = field(init=True, default_factory=dict)
-
     transforms: Transforms = field(init=True, default_factory=lambda: Transforms([]))
 
     def evolve(self, **kwargs) -> "Context":
@@ -187,6 +185,10 @@ def ref_value(self, instance: str) -> Iterator[Tuple[str | List[str], "Context"]
             return
         if instance in self.parameters:
             for v, path in self.parameters[instance].ref(self):
+
+                # validate that ref is possible with path
+                # need to evaluate if Fn::If would be not true if value is
+                # what it is
                 yield v, self.evolve(
                     path=self.path.evolve(
                         value_path=deque(["Parameters", instance]) + path
@@ -266,11 +268,6 @@ def ref(self, context: Context) -> Iterator[Any]:
         pass
 
 
-@dataclass
-class Condition:
-    instance: Any = field(init=True)
-
-
 @dataclass
 class Parameter(_Ref):
     """
@@ -448,19 +445,6 @@ def _init_transforms(transforms: Any) -> Transforms:
     return Transforms([])
 
 
-def _init_conditions(conditions: Any) -> dict[str, Condition]:
-    obj = {}
-    if not isinstance(conditions, dict):
-        raise ValueError("Conditions must be a object")
-    for k, v in conditions.items():
-        try:
-            obj[k] = Condition(v)
-        except ValueError:
-            pass
-
-    return obj
-
-
 def _init_mappings(mappings: Any) -> dict[str, Map]:
     obj = {}
     if not isinstance(mappings, dict):
@@ -489,9 +473,9 @@ def create_context_for_template(cfn):
 
     transforms = _init_transforms(cfn.template.get("Transform", []))
 
-    conditions = {}
+    conditions = Conditions({})
     try:
-        conditions = _init_conditions(cfn.template.get("Conditions", {}))
+        conditions = Conditions.create_from_instance(cfn.template.get("Conditions", {}))
     except (ValueError, AttributeError):
         pass
 

src/cfnlint/context/context.py

@@ -1 +1 @@
-{"etag": "\"d0827f5391a01752db21fee73f3bb56f\"", "url": "https://schema.cloudformation.eu-south-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"8e21dc9f4caa5b99df836d2724e85007\"", "url": "https://schema.cloudformation.eu-south-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/123ba181485ae293d5bd09722af0c19d5a0d14c62111ff864923fc7b7960dda6.meta.json

@@ -1 +1 @@
-{"etag": "\"2c3fe9abad68e57f03edaa326b343db6\"", "url": "https://schema.cloudformation.us-gov-east-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"3efb1f36bf2069dfd90693d73255b99b\"", "url": "https://schema.cloudformation.us-gov-east-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/18624fcc4a1c571691d10b2508e6be565e4752bbc10d9552de8df8f81348c42b.meta.json

@@ -1 +1 @@
-{"etag": "\"edbad4a5419cb79a91b306b985b73155\"", "url": "https://schema.cloudformation.me-south-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"e862b8d52f9fb2a4800ed9ae537c381d\"", "url": "https://schema.cloudformation.me-south-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/227d6e59c86482f7153466759080e65963a1bf4413531ad420ff60a5a0d7965d.meta.json

@@ -1 +1 @@
-{"etag": "\"721feac4151695b971f278d8036d377c\"", "url": "https://schema.cloudformation.us-gov-west-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"f0cbfdd2a88a3e39fe4587698aece4bc\"", "url": "https://schema.cloudformation.us-gov-west-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/23be708e675cb6098b08969e4dbbc3f54cfc32461d10e077e7e5de1fc25d8b8f.meta.json

@@ -1 +1 @@
-{"etag": "\"b1def23a3f79fa2a029ccfbb10446a45\"", "url": "https://schema.cloudformation.me-central-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"b995e7d567bfe5107c701b7708ccc12c\"", "url": "https://schema.cloudformation.me-central-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/26cf4521b683d3267844178a6bcd1d0ad3fe2e7838c23f6acd054944cb2b1618.meta.json

@@ -1 +1 @@
-{"etag": "\"3ed4f5619dadc27801d4a7a38863f8be\"", "url": "https://schema.cloudformation.eu-west-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"71b34442c9fb5fae86f1a0ef0bca7c70\"", "url": "https://schema.cloudformation.eu-west-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/276cecfeb1ec5e608e2aaa06925a2da57e9907e4a512c10ddae70b98b4dada43.meta.json

@@ -1 +1 @@
-{"etag": "\"c89014c462ab96b20b6cd5b719c331f4\"", "url": "https://schema.cloudformation.af-south-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"03a41aa9d5c778053c384b4135e05f42\"", "url": "https://schema.cloudformation.af-south-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/42155835f382d82337be3d2bf832bada376aa3fe15197e3bb0e9290ff8719b4e.meta.json

@@ -1 +1 @@
-{"etag": "\"4678f072d4101c242220c89a8dbf3939\"", "url": "https://schema.cloudformation.us-west-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"dc0a4ce69ad2a682aa4f63ccfc0c9880\"", "url": "https://schema.cloudformation.us-west-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/42e9df95722b6524cd001503b6750b86f60a7b5acfc406ebb10d5748cbb8ed41.meta.json

@@ -1 +1 @@
-{"etag": "\"6b48036379a0751d366f95bcbc4b3192\"", "url": "https://schema.cloudformation.eu-central-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"3293c078f8550d3960de9ee1279093bc\"", "url": "https://schema.cloudformation.eu-central-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/4fbb29b69678acdd32c5758ed43ead9bf35136af536e92a84ccbaf062c315066.meta.json

@@ -1 +1 @@
-{"etag": "\"d23dce937982dc37fa7044b43fffd977\"", "url": "https://schema.cloudformation.ap-south-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"f24d7e523686f97241c4735c1840d62e\"", "url": "https://schema.cloudformation.ap-south-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/56584c7d00e444de640bef01fc2c630804470222e5e4c690bacef5312891581d.meta.json

@@ -1 +1 @@
-{"etag": "\"f376b05bbeeefd37c12e7245754d6c48\"", "url": "https://schema.cloudformation.ap-southeast-4.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"9571fcb8dfb44407cfd91787059d29d4\"", "url": "https://schema.cloudformation.ap-southeast-4.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/583721567eccd1d5855daa623819df1a646b563d773e34b020d0ddeab2fe195b.meta.json

@@ -1 +1 @@
-{"etag": "\"598ef6013e6125ca185b72e6f942afca\"", "url": "https://schema.cloudformation.us-east-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"0901a777ed5ca3b8655822dd065e606d\"", "url": "https://schema.cloudformation.us-east-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/6316ae24f21cb620947aa250bebbee69548d44cc32e246ec9d7742088a2c17f8.meta.json

@@ -1 +1 @@
-{"etag": "\"8930df3c87aaf45508bdc05f0e8a0eba\"", "url": "https://schema.cloudformation.ap-southeast-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"6e7282388d60ba18f7a1e810c32ae5e6\"", "url": "https://schema.cloudformation.ap-southeast-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/81e1cc73ff2daf7d1e1eca393c2d1fdd98ac34d4109512e0e0947ef752dcb9c9.meta.json

@@ -1 +1 @@
-{"etag": "\"2e2def035877586c429f950f7d8b5e65\"", "url": "https://schema.cloudformation.ap-northeast-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"4481d14e13ecb83021f3fa7732a072d4\"", "url": "https://schema.cloudformation.ap-northeast-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/8adeabf0a09b37a8ed924aea799005947e4a4542365d35fd75466abcf306eeca.meta.json

@@ -1 +1 @@
-{"etag": "\"397de2415e3b51b7aa0284bf8a2a2e70\"", "url": "https://schema.cloudformation.ap-southeast-3.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"b18c7ffb485d2d897035614eacbb4ff7\"", "url": "https://schema.cloudformation.ap-southeast-3.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/8b8b0cee4df1ef0947a8289e8ec0c67869b7533eabab32ecfc0a00cb19e55a5f.meta.json

@@ -1 +1 @@
-{"etag": "\"8c39a53d13779450ebf7d03191cf6bc9\"", "url": "https://schema.cloudformation.ap-east-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"8da7617ff7251272a0ecc94bb36d8c23\"", "url": "https://schema.cloudformation.ap-east-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/b1f069477cd577cde04dfe1b323c0bb0e783fe32b6bb6b13774c32fcca1d303a.meta.json

@@ -1 +1 @@
-{"etag": "\"bf0cc975ad2ddb6a5b1b15b1b3b262d7\"", "url": "https://schema.cloudformation.sa-east-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"a8ef7c07a5b62c4de0f8e6fb79fc4b0b\"", "url": "https://schema.cloudformation.sa-east-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/c7ada205073390b33b7593ef8f304b9705f2567698dfdfa979bf0ccdb68cb856.meta.json

@@ -1 +1 @@
-{"etag": "\"644e4e47b1e4aad9af5a6936855db14d\"", "url": "https://schema.cloudformation.ap-southeast-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"78df17182748cca99b8a8efba79d2ecd\"", "url": "https://schema.cloudformation.ap-southeast-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/d24ce9a45a014b1ff04d479422ea956e92030ae5c03d7451980a15735e557edb.meta.json

@@ -1 +1 @@
-{"etag": "\"709be88da2e091792f0123cb2574e962\"", "url": "https://schema.cloudformation.ca-west-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"b2bf37b2de7adcd8ebe025b8c1b7e3f3\"", "url": "https://schema.cloudformation.ca-west-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/d85e2e061cacfcffe4902adb1074a04e6bb7f975b606f8db57532faddfcdd8c8.meta.json

@@ -1 +1 @@
-{"etag": "\"1bab187bb389ee733aac163e25414e21\"", "url": "https://schema.cloudformation.eu-central-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"586ccc967824b79951230311f96a5c8f\"", "url": "https://schema.cloudformation.eu-central-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/d8e41d35f4f8922b66525dea2c66d72a73ff097c685cda0a63c08a6416dc58ed.meta.json

@@ -1 +1 @@
-{"etag": "\"b4cfe9d40d2399256ed406cd41c4eb59\"", "url": "https://schema.cloudformation.eu-north-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"f4b1a7c7eb7851f07eb698cffc58ac08\"", "url": "https://schema.cloudformation.eu-north-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/dd98171253ebc36f5b78e247f3132b5f25c8d66a1f84939600616bab42579541.meta.json

@@ -1 +1 @@
-{"etag": "\"4d3a350d93c07575dbe1e6a53f0bf334\"", "url": "https://schema.cloudformation.eu-south-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"997d1c02e4833e76905453998aeadaf1\"", "url": "https://schema.cloudformation.eu-south-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/df4945435575c690a2651bb31e7a9b48972142778e1ff452383ede2ad4bac3d7.meta.json

@@ -1 +1 @@
-{"etag": "\"e30e1b7061ecf6c46d1b495c9d658e42\"", "url": "https://schema.cloudformation.ca-central-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"9c8967d0c5f53fc40ed297cd2b08aa35\"", "url": "https://schema.cloudformation.ca-central-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/e5301e07e25fa2c35d2c7e1f9dcf720826b315ef6f38515840537c02de23abe2.meta.json

@@ -1 +1 @@
-{"etag": "\"240e8979bb194a0e76adde5a119be6fa\"", "url": "https://schema.cloudformation.eu-west-3.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"189d61fc63b82d5afd6fa1d7c24df012\"", "url": "https://schema.cloudformation.eu-west-3.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/e8b3dacc1675b478e8c7392b51f41467cf908a34e6b4c3fb3e97e2b584f651ca.meta.json

@@ -1 +1 @@
-{"etag": "\"7fe1519ba3544adef2fed648f7cdcda5\"", "url": "https://schema.cloudformation.ap-northeast-3.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"ed6a3644fb2576d2c563b9b5dc7e4f99\"", "url": "https://schema.cloudformation.ap-northeast-3.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/ea0f7b8f144feb225afe73a24dfdf993318c41c71c21b0a17d4f68d82c5aee21.meta.json

@@ -1 +1 @@
-{"etag": "\"d9bc56584ee4ec888eab4dc0d1e7c0cf\"", "url": "https://schema.cloudformation.ap-south-2.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"15ff053fecb2d9f390ead75a04a9fc40\"", "url": "https://schema.cloudformation.ap-south-2.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/f49718b210ea89ff182ae51cb7004366b9e2e4d5e38136a5be83b6a55e7a82a1.meta.json

@@ -1 +1 @@
-{"etag": "\"187b7949251051e2debb57afc128bfe9\"", "url": "https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"cf72a169c13940c71da83696f76618c4\"", "url": "https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/f54eee6f8ad9619f41835b700369cdbb41c64a9c91b2fa5b4928c0d9b2f780b0.meta.json

@@ -1 +1 @@
-{"etag": "\"7e7e5a070b1128c8756143f7a5906ab9\"", "url": "https://schema.cloudformation.il-central-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"5789ec51cc517240c3ff889d308c1c8d\"", "url": "https://schema.cloudformation.il-central-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/f6f35a459759d6c132fa2fe798cefbd5b2d398fe33547eed780b9b70f10eb4a2.meta.json

@@ -1 +1 @@
-{"etag": "\"751a5f39158897603b1a80a1f38de264\"", "url": "https://schema.cloudformation.eu-west-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"4416b41626f4d09ed7365062e52517d8\"", "url": "https://schema.cloudformation.eu-west-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/fa657351d8e89c40ba6b82c4b1f5e1b5e50a1638ffe0a5dba0d8805c190a05f8.meta.json

@@ -1 +1 @@
-{"etag": "\"013c70fbc5816a1ff09667ee596ce5d5\"", "url": "https://schema.cloudformation.ap-northeast-1.amazonaws.com/CloudformationSchema.zip"}
+{"etag": "\"a384225460a33fa84f23423dae5ba6ba\"", "url": "https://schema.cloudformation.ap-northeast-1.amazonaws.com/CloudformationSchema.zip"}

src/cfnlint/data/DownloadsMetadata/ff02b7d808c1c00053f09aa43a50addf3b69878d351cffd417dc9a457df808af.meta.json

@@ -1,4 +1,9 @@
 [
+ {
+  "op": "add",
+  "path": "/properties/SourceSecurityGroup/properties/GroupName/format",
+  "value": "AWS::EC2::SecurityGroup.GroupName"
+ },
  {
   "op": "add",
   "path": "/properties/SecurityGroups/format",

src/cfnlint/data/schemas/patches/extensions/all/aws_elasticloadbalancing_loadbalancer/format.json

@@ -37,6 +37,7 @@
   "value": {
    "properties": {
     "GroupName": {
+     "format": "AWS::EC2::SecurityGroup.GroupName",
      "type": "string"
     },
     "OwnerAlias": {