Skip to content

Commit f05c8d8

Browse files
author
Colman Yau
committed
Remove unnecessary logic in retry condition
1 parent 4069317 commit f05c8d8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

aws-codeguruprofiler-profilinggroup/src/main/java/software/amazon/codeguruprofiler/profilinggroup/CodeGuruProfilerClientBuilder.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import software.amazon.awssdk.core.client.config.ClientOverrideConfiguration;
44
import software.amazon.awssdk.core.internal.retry.SdkDefaultRetrySetting;
55
import software.amazon.awssdk.core.exception.AbortedException;
6-
import software.amazon.awssdk.core.exception.SdkClientException;
76
import software.amazon.awssdk.core.retry.RetryPolicy;
7+
import software.amazon.awssdk.core.retry.RetryPolicyContext;
88
import software.amazon.awssdk.core.retry.backoff.BackoffStrategy;
99
import software.amazon.awssdk.core.retry.backoff.EqualJitterBackoffStrategy;
1010
import software.amazon.awssdk.core.retry.conditions.OrRetryCondition;
@@ -81,14 +81,14 @@ private static RetryPolicy getRetryPolicy() {
8181
private static RetryCondition getRetryCondition() {
8282
return OrRetryCondition.create(
8383
RetryCondition.defaultRetryCondition(), // Pull in SDK defaults
84-
retryAbortedExceptionCondition() // https://github.com/aws/aws-sdk-java-v2/issues/1684
84+
shouldRetryAbortedException() // https://github.com/aws/aws-sdk-java-v2/issues/1684
8585
);
8686
}
8787

88-
private static RetryCondition retryAbortedExceptionCondition() {
89-
return c -> c.exception().getClass().equals(SdkClientException.class) &&
90-
c.exception().getCause() != null &&
91-
c.exception().getCause().getClass().equals(AbortedException.class);
88+
private static RetryCondition shouldRetryAbortedException() {
89+
return (RetryPolicyContext c) ->
90+
c.exception().getCause() != null &&
91+
c.exception().getCause().getClass().equals(AbortedException.class);
9292
}
9393

9494
private static SdkHttpClient getHttpClient() {
@@ -98,7 +98,7 @@ private static SdkHttpClient getHttpClient() {
9898
.build();
9999
}
100100

101-
public static ClientOverrideConfiguration getClientConfiguration() {
101+
static ClientOverrideConfiguration getClientConfiguration() {
102102
return ClientOverrideConfiguration.builder()
103103
.retryPolicy(getRetryPolicy())
104104
.apiCallTimeout(OVERALL_TIMEOUT)

0 commit comments

Comments
 (0)