Skip to content

Commit ca04437

Browse files
Laurence Armstrongclareliguori
Laurence Armstrong
authored andcommitted
Fix calling setSecret
1 parent 77f2df7 commit ca04437

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,18 @@ function exportCredentials(params){
7878
// AWS_ACCESS_KEY_ID:
7979
// Specifies an AWS access key associated with an IAM user or role
8080
core.exportVariable('AWS_ACCESS_KEY_ID', accessKeyId);
81-
core.setSecret('AWS_ACCESS_KEY_ID', accessKeyId);
81+
core.setSecret(accessKeyId);
8282

8383
// AWS_SECRET_ACCESS_KEY:
8484
// Specifies the secret key associated with the access key. This is essentially the "password" for the access key.
8585
core.exportVariable('AWS_SECRET_ACCESS_KEY', secretAccessKey);
86-
core.setSecret('AWS_SECRET_ACCESS_KEY', secretAccessKey);
86+
core.setSecret(secretAccessKey);
8787

8888
// AWS_SESSION_TOKEN:
8989
// Specifies the session token value that is required if you are using temporary security credentials.
9090
if (sessionToken) {
9191
core.exportVariable('AWS_SESSION_TOKEN', sessionToken);
92-
core.setSecret('AWS_SESSION_TOKEN', sessionToken);
92+
core.setSecret(sessionToken);
9393
}
9494
}
9595

index.test.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ describe('Configure AWS Credentials', () => {
100100
expect(core.exportVariable).toHaveBeenCalledTimes(5);
101101
expect(core.setSecret).toHaveBeenCalledTimes(4);
102102
expect(core.exportVariable).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
103-
expect(core.setSecret).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
103+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_ACCESS_KEY_ID);
104104
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
105-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
105+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_SECRET_ACCESS_KEY);
106106
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SESSION_TOKEN', FAKE_SESSION_TOKEN);
107-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SESSION_TOKEN', FAKE_SESSION_TOKEN);
107+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_SESSION_TOKEN);
108108
expect(core.exportVariable).toHaveBeenCalledWith('AWS_DEFAULT_REGION', FAKE_REGION);
109109
expect(core.exportVariable).toHaveBeenCalledWith('AWS_REGION', FAKE_REGION);
110110
expect(core.setOutput).toHaveBeenCalledWith('aws-account-id', FAKE_ACCOUNT_ID);
@@ -122,9 +122,9 @@ describe('Configure AWS Credentials', () => {
122122
expect(core.exportVariable).toHaveBeenCalledTimes(4);
123123
expect(core.setSecret).toHaveBeenCalledTimes(3);
124124
expect(core.exportVariable).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
125-
expect(core.setSecret).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
125+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_ACCESS_KEY_ID);
126126
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
127-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
127+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_SECRET_ACCESS_KEY);
128128
expect(core.exportVariable).toHaveBeenCalledWith('AWS_DEFAULT_REGION', 'eu-west-1');
129129
expect(core.exportVariable).toHaveBeenCalledWith('AWS_REGION', 'eu-west-1');
130130
expect(core.setOutput).toHaveBeenCalledWith('aws-account-id', FAKE_ACCOUNT_ID);
@@ -141,9 +141,9 @@ describe('Configure AWS Credentials', () => {
141141
expect(mockStsAssumeRole).toHaveBeenCalledTimes(0);
142142
expect(core.exportVariable).toHaveBeenCalledTimes(4);
143143
expect(core.exportVariable).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
144-
expect(core.setSecret).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_ACCESS_KEY_ID);
144+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_ACCESS_KEY_ID);
145145
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
146-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_SECRET_ACCESS_KEY);
146+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_SECRET_ACCESS_KEY);
147147
expect(core.exportVariable).toHaveBeenCalledWith('AWS_DEFAULT_REGION', 'us-east-1');
148148
expect(core.exportVariable).toHaveBeenCalledWith('AWS_REGION', 'us-east-1');
149149
expect(core.setOutput).toHaveBeenCalledWith('aws-account-id', FAKE_ACCOUNT_ID);
@@ -183,11 +183,11 @@ describe('Configure AWS Credentials', () => {
183183
expect(core.exportVariable).toHaveBeenCalledTimes(5);
184184
expect(core.setSecret).toHaveBeenCalledTimes(4);
185185
expect(core.exportVariable).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_STS_ACCESS_KEY_ID);
186-
expect(core.setSecret).toHaveBeenCalledWith('AWS_ACCESS_KEY_ID', FAKE_STS_ACCESS_KEY_ID);
186+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_STS_ACCESS_KEY_ID);
187187
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_STS_SECRET_ACCESS_KEY);
188-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SECRET_ACCESS_KEY', FAKE_STS_SECRET_ACCESS_KEY);
188+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_STS_SECRET_ACCESS_KEY);
189189
expect(core.exportVariable).toHaveBeenCalledWith('AWS_SESSION_TOKEN', FAKE_STS_SESSION_TOKEN);
190-
expect(core.setSecret).toHaveBeenCalledWith('AWS_SESSION_TOKEN', FAKE_STS_SESSION_TOKEN);
190+
expect(core.setSecret).toHaveBeenCalledWith(FAKE_STS_SESSION_TOKEN);
191191
expect(core.exportVariable).toHaveBeenCalledWith('AWS_DEFAULT_REGION', FAKE_REGION);
192192
expect(core.exportVariable).toHaveBeenCalledWith('AWS_REGION', FAKE_REGION);
193193
expect(core.setOutput).toHaveBeenCalledWith('aws-account-id', FAKE_ACCOUNT_ID);

0 commit comments

Comments
 (0)