Skip to content

Commit 145b306

Browse files
chore(code clean-up): optimize propsFilter
Move ‘var keys = Object.keys(props);’ outside of the items.forEach(…) loop. As previously written, keys will be re-instantiated on every iteration of the forEach loop.
1 parent f953cc3 commit 145b306

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

examples/demo.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ app.filter('propsFilter', function() {
1313
var out = [];
1414

1515
if (angular.isArray(items)) {
16+
var keys = Object.keys(props);
17+
1618
items.forEach(function(item) {
1719
var itemMatches = false;
1820

19-
var keys = Object.keys(props);
2021
for (var i = 0; i < keys.length; i++) {
2122
var prop = keys[i];
2223
var text = props[prop].toLowerCase();

0 commit comments

Comments
 (0)