[flake8-django] Recognize other magic methods (DJ012) (#15365)

Author: InSyncWithFoo

crates/ruff_linter/resources/test/fixtures/flake8_django/DJ012.py

@@ -145,3 +145,11 @@ def __str__(self):
 
     first_name = models.CharField(max_length=32)
 
+
+# https://github.com/astral-sh/ruff/issues/13892
+class DunderMethodOtherThanStrBeforeSave(models.Model):
+    name = models.CharField()
+
+    def __init__(self, *args, **kwargs): ...
+
+    def save(*args, **kwargs): ...

crates/ruff_linter/src/rules/flake8_django/rules/unordered_body_content_in_model.rs

@@ -2,6 +2,7 @@ use std::fmt;
 
 use ruff_diagnostics::{Diagnostic, Violation};
 use ruff_macros::{derive_message_formats, ViolationMetadata};
+use ruff_python_ast::helpers::is_dunder;
 use ruff_python_ast::{self as ast, Expr, Stmt};
 use ruff_python_semantic::{Modules, SemanticModel};
 use ruff_text_size::Ranged;
@@ -131,7 +132,7 @@ enum ContentType {
     FieldDeclaration,
     ManagerDeclaration,
     MetaClass,
-    StrMethod,
+    MagicMethod,
     SaveMethod,
     GetAbsoluteUrlMethod,
     CustomMethod,
@@ -143,7 +144,7 @@ impl fmt::Display for ContentType {
             ContentType::FieldDeclaration => f.write_str("field declaration"),
             ContentType::ManagerDeclaration => f.write_str("manager declaration"),
             ContentType::MetaClass => f.write_str("`Meta` class"),
-            ContentType::StrMethod => f.write_str("`__str__` method"),
+            ContentType::MagicMethod => f.write_str("Magic method"),
             ContentType::SaveMethod => f.write_str("`save` method"),
             ContentType::GetAbsoluteUrlMethod => f.write_str("`get_absolute_url` method"),
             ContentType::CustomMethod => f.write_str("custom method"),
@@ -177,7 +178,7 @@ fn get_element_type(element: &Stmt, semantic: &SemanticModel) -> Option<ContentT
             }
         }
         Stmt::FunctionDef(ast::StmtFunctionDef { name, .. }) => match name.as_str() {
-            "__str__" => Some(ContentType::StrMethod),
+            name if is_dunder(name) => Some(ContentType::MagicMethod),
             "save" => Some(ContentType::SaveMethod),
             "get_absolute_url" => Some(ContentType::GetAbsoluteUrlMethod),
             _ => Some(ContentType::CustomMethod),

crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ012_DJ012.py.snap

@@ -18,7 +18,7 @@ DJ012.py:43:5: DJ012 Order of model's inner classes, methods, and fields does no
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ DJ012
    |
 
-DJ012.py:56:5: DJ012 Order of model's inner classes, methods, and fields does not follow the Django Style Guide: `__str__` method should come before custom method
+DJ012.py:56:5: DJ012 Order of model's inner classes, methods, and fields does not follow the Django Style Guide: Magic method should come before custom method
    |
 54 |           pass
 55 |