Skip to content

Commit 0a26201

Browse files
authored
Merge clippy and clippy (wasm) jobs on CI (#5447)
## Summary The clippy wasm job rarely fails if regular clippy doesn't, wasm clippy still compiles a lot of native dependencies for the proc macro and we have less CI jobs overall, so i think this an improvement to our CI. ```shell $ CARGO_TARGET_DIR=target-wasm cargo clippy -p ruff_wasm --target wasm32-unknown-unknown --all-features -j 2 -- -D warnings $ du -sh target-wasm/* 12K target-wasm/CACHEDIR.TAG 582M target-wasm/debug 268M target-wasm/wasm32-unknown-unknown ``` ## Test plan n/a
1 parent 0e67757 commit 0a26201

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

.github/workflows/ci.yaml

+4-12
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,17 @@ jobs:
3131
cargo-clippy:
3232
name: "cargo clippy"
3333
runs-on: ubuntu-latest
34-
steps:
35-
- uses: actions/checkout@v3
36-
- name: "Install Rust toolchain"
37-
run: |
38-
rustup component add clippy
39-
- uses: Swatinem/rust-cache@v2
40-
- run: cargo clippy --workspace --all-targets --all-features -- -D warnings
41-
42-
cargo-clippy-wasm:
43-
name: "cargo clippy (wasm)"
44-
runs-on: ubuntu-latest
4534
steps:
4635
- uses: actions/checkout@v3
4736
- name: "Install Rust toolchain"
4837
run: |
4938
rustup component add clippy
5039
rustup target add wasm32-unknown-unknown
5140
- uses: Swatinem/rust-cache@v2
52-
- run: cargo clippy -p ruff_wasm --target wasm32-unknown-unknown --all-features -- -D warnings
41+
- name: "Clippy"
42+
run: cargo clippy --workspace --all-targets --all-features -- -D warnings
43+
- name: "Clippy (wasm)"
44+
run: cargo clippy -p ruff_wasm --target wasm32-unknown-unknown --all-features -- -D warnings
5345

5446
cargo-test:
5547
strategy:

0 commit comments

Comments
 (0)