Fix bug in repeatedly parsing scala#34

Author: Amal Elshihaby

src/main/scala/scala/util/parsing/combinator/Parsers.scala

@@ -669,7 +669,7 @@ trait Parsers {
    * @param p a `Parser` that is to be applied successively to the input
    * @return A parser that returns a list of results produced by repeatedly applying `p` to the input.
    */
-  def rep[T](p: => Parser[T]): Parser[List[T]] = rep1(p) | success(List())
+  def rep[T](p: => Parser[T]): Parser[List[T]] = rep1(p)
 
   /** A parser generator for interleaved repetitions.
    *

src/test/scala/scala/util/parsing/combinator/JavaTokenParsersTest.scala

@@ -55,4 +55,28 @@ class JavaTokenParsersTest {
     parseFailure("with space", 6)
   }
 
+  @Test
+  def repeatedlyParsesTest: Unit = {
+    object TestTokenParser extends JavaTokenParsers
+    import TestTokenParser._
+    val p = ident ~ "(?i)AND".r.*
+
+    val parseResult = parseAll(p, "start start")
+    parseResult match {
+      case e @ Failure(message, next) =>
+        assertEquals(next.pos.column, 7)
+        assert(message.endsWith("string matching regex `(?i)AND' expected but `s' found"))
+      case _ => sys.error(parseResult.toString)
+    }
+
+    val parseResult2 = parseAll(p, "start AND AND")
+    parseResult2 match {
+      case Success(r, _) =>
+        assertEquals("start", r._1)
+        assertEquals("AND AND", r._2.mkString(" "))
+      case _ => sys.error(parseResult.toString)
+    }
+  }
+
+
 }