RPL target address publish update

RPL slow timer check automatically if RPL learn new instances or Interface got new address. Earlier Address Callback was handling this and DIO message handler.
Now functionality is centralised to one place.

Change-Id: I822980153502f3581df922a3005c3da3540871b9

Author: Juha Heiskanen

source/RPL/rpl_control.c

@@ -151,17 +151,6 @@ static void rpl_control_publish_own_addresses(rpl_domain_t *domain, rpl_instance
     }
 }
 
-static void rpl_control_publish_own_address(rpl_domain_t *domain, const if_address_entry_t *addr)
-{
-    ns_list_foreach(rpl_instance_t, instance, &domain->instances) {
-        if (!rpl_instance_am_root(instance)) {
-            uint32_t descriptor = 0;
-            bool want_descriptor = rpl_policy_target_descriptor_for_own_address(domain, addr->address, addr->source, addr->data, &descriptor);
-            rpl_instance_publish_dao_target(instance, addr->address, 128, addr->valid_lifetime, true, want_descriptor, descriptor);
-        }
-    }
-}
-
 void rpl_control_publish_host_address(rpl_domain_t *domain, const uint8_t addr[16], uint32_t lifetime)
 {
     ns_list_foreach(rpl_instance_t, instance, &domain->instances) {
@@ -260,10 +249,6 @@ static void rpl_control_addr_notifier(struct protocol_interface_info_entry *inte
     }
 
     switch (reason) {
-        case ADDR_CALLBACK_DAD_COMPLETE:
-        case ADDR_CALLBACK_REFRESHED:
-            rpl_control_publish_own_address(interface->rpl_domain, addr);
-            break;
         case ADDR_CALLBACK_DELETED:
             rpl_control_unpublish_address(interface->rpl_domain, addr->address);
             break;
@@ -345,11 +330,7 @@ void rpl_control_set_domain_on_interface(protocol_interface_info_entry_t *cur, r
         cur->rpl_domain = domain;
         addr_add_group(cur, ADDR_LINK_LOCAL_ALL_RPL_NODES);
     }
-    ns_list_foreach(if_address_entry_t, addr, &cur->ip_addresses) {
-        if (!addr_is_ipv6_link_local(addr->address)) {
-            rpl_control_publish_own_address(domain, addr);
-        }
-    }
+
     if (downstream) {
         domain->non_storing_downstream_interface = cur->id;
     }
@@ -898,10 +879,6 @@ static buffer_t *rpl_control_dio_handler(protocol_interface_info_entry_t *cur, r
         if (!instance) {
             return buffer_free(buf);
         }
-
-        if ((g_mop_prf & RPL_MODE_MASK) != RPL_MODE_NO_DOWNWARD) {
-            rpl_control_publish_own_addresses(domain, instance);
-        }
     }
 
     /* Lookup any existing neighbour entry */
@@ -1628,6 +1605,7 @@ void rpl_control_slow_timer(uint16_t seconds)
 
     ns_list_foreach(rpl_domain_t, domain, &rpl_domains) {
         ns_list_foreach_safe(rpl_instance_t, instance, &domain->instances) {
+            rpl_control_publish_own_addresses(domain, instance);
             rpl_instance_slow_timer(instance, seconds);
             rpl_downward_dao_slow_timer(instance, seconds);
             /* We purge one item from each instance, so as not to favour one domain or instance */

source/RPL/rpl_downward.c

@@ -345,8 +345,9 @@ void rpl_instance_publish_dao_target(rpl_instance_t *instance, const uint8_t *pr
 {
     rpl_dao_target_t *target = rpl_instance_lookup_published_dao_target(instance, prefix, prefix_len);
     if (target) {
+        int diff = target->lifetime > valid_lifetime ? target->lifetime - valid_lifetime : valid_lifetime - target->lifetime;
         target->lifetime = valid_lifetime;
-        if (!own) {
+        if (!own && diff > 60) {
             /* For non-owned targets, publish triggers a refresh */
             rpl_downward_target_refresh(target);
             rpl_instance_dao_trigger(instance, 0);