Fix: 'no-shared-component-data' false positive when using arrow functions (fixes vuejs#154)(vuejs#156)

Author: armano2

lib/rules/no-shared-component-data.js

@@ -18,6 +18,7 @@ function create (context) {
         p.key.type === 'Identifier' &&
         p.key.name === 'data' &&
         p.value.type !== 'FunctionExpression' &&
+        p.value.type !== 'ArrowFunctionExpression' &&
         p.value.type !== 'Identifier'
       )
       .forEach(cp => {
@@ -41,9 +42,7 @@ module.exports = {
       recommended: false
     },
     fixable: null,  // or "code" or "whitespace"
-    schema: [
-      // fill in your schema
-    ]
+    schema: []
   },
 
   create

tests/lib/rules/no-shared-component-data.js

@@ -12,6 +12,12 @@ const rule = require('../../../lib/rules/no-shared-component-data')
 
 const RuleTester = require('eslint').RuleTester
 
+const parserOptions = {
+  ecmaVersion: 7,
+  sourceType: 'module',
+  ecmaFeatures: { experimentalObjectRestSpread: true }
+}
+
 // ------------------------------------------------------------------------------
 // Tests
 // ------------------------------------------------------------------------------
@@ -30,7 +36,8 @@ ruleTester.run('no-shared-component-data', rule, {
             }
           }
         })
-      `
+      `,
+      parserOptions
     },
     {
       filename: 'test.js',
@@ -44,11 +51,7 @@ ruleTester.run('no-shared-component-data', rule, {
           }
         })
       `,
-      parserOptions: {
-        ecmaVersion: 7,
-        sourceType: 'module',
-        ecmaFeatures: { experimentalObjectRestSpread: true }
-      }
+      parserOptions
     },
     {
       filename: 'test.js',
@@ -71,7 +74,7 @@ ruleTester.run('no-shared-component-data', rule, {
           }
         })
       `,
-      parserOptions: { ecmaVersion: 6 }
+      parserOptions
     },
     {
       filename: 'test.vue',
@@ -84,7 +87,7 @@ ruleTester.run('no-shared-component-data', rule, {
           }
         }
       `,
-      parserOptions: { ecmaVersion: 6, sourceType: 'module' }
+      parserOptions
     },
     {
       filename: 'test.vue',
@@ -93,7 +96,7 @@ ruleTester.run('no-shared-component-data', rule, {
           ...foo
         }
       `,
-      parserOptions: { ecmaVersion: 6, sourceType: 'module', ecmaFeatures: { experimentalObjectRestSpread: true }}
+      parserOptions
     },
     {
       filename: 'test.vue',
@@ -102,7 +105,18 @@ ruleTester.run('no-shared-component-data', rule, {
           data
         }
       `,
-      parserOptions: { ecmaVersion: 6, sourceType: 'module' }
+      parserOptions
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          data: () => {
+
+          }
+        }
+      `,
+      parserOptions
     }
   ],
 
@@ -116,7 +130,7 @@ ruleTester.run('no-shared-component-data', rule, {
           }
         })
       `,
-      parserOptions: { ecmaVersion: 6 },
+      parserOptions,
       errors: [{
         message: '`data` property in component must be a function',
         line: 3
@@ -131,7 +145,7 @@ ruleTester.run('no-shared-component-data', rule, {
           }
         }
       `,
-      parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+      parserOptions,
       errors: [{
         message: '`data` property in component must be a function',
         line: 3