Skip to content

Commit ffee773

Browse files
committed
Remove fork filter conditional from Go nightly build workflow
This conditional was intended to prevent the workflow from causing confusion and annoyance to contributors with no need or interest in publishing a nightly build as it failed daily in their forks due to the necessary secrets not having been defined. Since the time this was added to the workflow, GitHub Actions has been changed so that, even after enabling workflows globally, scheduled workflows are disabled in forks. The forker must manually enable each scheduled workflow. I think that the sort of contributor who is savvy enough to enable workflows is also savvy enough to understand from the workflow name that it does not apply to their fork and skip enabling it. Even if they did accidentally enable it, they will remember doing so when the workflow fails later that day.
1 parent 61ad067 commit ffee773

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

workflow-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ on:
88

99
jobs:
1010
create-nightly-artifacts:
11-
# This workflow is only of value to the arduino/arduino-cli repository and
12-
# would always fail in forks
13-
if: github.repository == 'arduino/arduino-cli'
1411
runs-on: ubuntu-latest
1512

1613
steps:

workflow-templates/publish-go-nightly-task.yml

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ on:
88

99
jobs:
1010
create-nightly-artifacts:
11-
# This workflow is only of value to the arduino/arduino-cli repository and
12-
# would always fail in forks
13-
if: github.repository == 'arduino/arduino-cli'
1411
runs-on: ubuntu-latest
1512

1613
steps:

0 commit comments

Comments
 (0)