Skip to content

Commit cf5dd94

Browse files
committed
Remove useless comments re: actions/download-artifact from Go release workflow
Some cryptic comments were added referring to a "v1". These are explained here: https://github.com/actions/download-artifact#compatibility-between-v1-and-v2 It was definitely important to explain the reason for the need to add the `path` input in the commit/PR that updated the action from v1 to v2. But this information is not of ongoing value to the reader of the workflow code. We only need to understand how the version of the action that is currently in use works, and that is fairly clear just from the input name, with details readily available in the action's documentation. For this reason, the comments only serve to make the workflow more confusing.
1 parent 067ea8a commit cf5dd94

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

workflow-templates/dependabot/workflow-template-copies/.github/workflows/publish-go-nightly-task.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
uses: actions/download-artifact@v2
5757
with:
5858
name: ${{ env.ARTIFACT_NAME }}
59-
# to ensure compatibility with v1
6059
path: ${{ env.DIST_DIR }}
6160

6261
- name: Import Code-Signing Certificates
@@ -125,7 +124,6 @@ jobs:
125124
uses: actions/download-artifact@v2
126125
with:
127126
name: ${{ env.ARTIFACT_NAME }}
128-
# to ensure compatibility with v1
129127
path: ${{ env.DIST_DIR }}
130128

131129
- name: Upload release files on Arduino downloads servers

workflow-templates/publish-go-nightly-task.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
uses: actions/download-artifact@v2
5757
with:
5858
name: ${{ env.ARTIFACT_NAME }}
59-
# to ensure compatibility with v1
6059
path: ${{ env.DIST_DIR }}
6160

6261
- name: Import Code-Signing Certificates
@@ -125,7 +124,6 @@ jobs:
125124
uses: actions/download-artifact@v2
126125
with:
127126
name: ${{ env.ARTIFACT_NAME }}
128-
# to ensure compatibility with v1
129127
path: ${{ env.DIST_DIR }}
130128

131129
- name: Upload release files on Arduino downloads servers

0 commit comments

Comments
 (0)