Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

Author: umbynos

workflow-templates/publish-go-nightly-task.yml

@@ -107,8 +107,8 @@ jobs:
         run: |
           cat > "${{ env.GON_CONFIG_PATH }}" <<EOF
           # See: https://github.com/mitchellh/gon#configuration-file
-          source = [TODO_SOURCE_PATH]
-          bundle_id = TODO_BUNDLE_ID
+          source = ["${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_${{ matrix.artifact.name }}/${{ env.PROJECT_NAME }}"]
+          bundle_id = "cc.arduino.${{ env.PROJECT_NAME }}"
 
           sign {
             application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)"
@@ -139,7 +139,7 @@ jobs:
         run: |
           # GitHub's upload/download-artifact actions don't preserve file permissions,
           # so we need to add execution permission back until the action is made to do this.
-          chmod +x "${{ env.PROJECT_NAME }}_${{ matrix.artifact.name }}/${{ env.PROJECT_NAME }}"
+          chmod +x "${{ env.PROJECT_NAME }}_osx_${{ matrix.artifact.name }}/${{ env.PROJECT_NAME }}"
           # Use of an array here is required for globbing
           PACKAGE_FILENAME=(${{ env.PROJECT_NAME }}_nightly-*${{ matrix.artifact.path }})
           tar -czvf "$PACKAGE_FILENAME" \

workflow-templates/release-go-crosscompile-task.md

@@ -36,8 +36,6 @@ The following project-specific variables must be set/configured in `release-go-c
 - `PROJECT_NAME`
 - `AWS_PLUGIN_TARGET`
 - `GO_VERSION`: version of Go used for development of the project, use at least [GO 1.16 to be able to use 64-bit ARM architecture on macOS](https://tip.golang.org/doc/go1.16#ports)
-- `source`
-- `bundle_id`
 
 #### Repository secrets
 

workflow-templates/release-go-crosscompile-task.yml

@@ -118,8 +118,8 @@ jobs:
         run: |
           cat > "${{ env.GON_CONFIG_PATH }}" <<EOF
           # See: https://github.com/mitchellh/gon#configuration-file
-          source = [TODO_SOURCE_PATH]
-          bundle_id = TODO_BUNDLE_ID
+          source = ["${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_${{ matrix.artifact.name }}/${{ env.PROJECT_NAME }}"]
+          bundle_id = "cc.arduino.${{ env.PROJECT_NAME }}"
 
           sign {
             application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)"

workflow-templates/release-go-task.md

@@ -35,8 +35,6 @@ The following project-specific variables must be set in `release-go-task.yml`:
 
 - `PROJECT_NAME`
 - `AWS_PLUGIN_TARGET`
-- `source`
-- `bundle_id`
 
 #### Repository secrets
 

workflow-templates/release-go-task.yml

@@ -111,8 +111,8 @@ jobs:
         run: |
           cat > "${{ env.GON_CONFIG_PATH }}" <<EOF
           # See: https://github.com/mitchellh/gon#configuration-file
-          source = [TODO_SOURCE_PATH]
-          bundle_id = TODO_BUNDLE_ID
+          source = ["${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_osx_${{ matrix.artifact.name }}/${{ env.PROJECT_NAME }}"]
+          bundle_id = "cc.arduino.${{ env.PROJECT_NAME }}"
 
           sign {
             application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)"