Skip to content

Commit 97a1638

Browse files
committed
Only download required artifact in notarization job of release workflows
GitHub Workflows are used to automatically generate and publish production and nightly releases of the project. This is done for a range of host architectures, including macOS. The macOS builds are then put through a notarization process in a dedicated workflow job. GitHub Actions workflow artifacts are used to transfer the generated files between sequential jobs in the workflow. The builds are transferred between jobs by GitHub Actions workflow artifacts, one for each host architecture. Previously, the "notarize-macos" job matrix that performs the notarization unnecessarily downloaded all the build artifacts, even though each job only requires the relevant macOS artifact. This is inefficient. The better approach is to configure the "notarize-macos" jobs to only download the artifact they require.
1 parent 06e6a0e commit 97a1638

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

workflow-templates/publish-go-nightly-task.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ jobs:
101101
- name: Download artifacts
102102
uses: actions/download-artifact@v4
103103
with:
104-
pattern: ${{ env.ARTIFACT_PREFIX }}*
105-
merge-multiple: true
104+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
106105
path: ${{ env.DIST_DIR }}
107106

108107
- name: Import Code-Signing Certificates

workflow-templates/release-go-task.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ jobs:
110110
- name: Download artifacts
111111
uses: actions/download-artifact@v4
112112
with:
113-
pattern: ${{ env.ARTIFACT_PREFIX }}*
114-
merge-multiple: true
113+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
115114
path: ${{ env.DIST_DIR }}
116115

117116
- name: Import Code-Signing Certificates

0 commit comments

Comments
 (0)