Skip to content

Commit 4e7a852

Browse files
authored
Merge pull request #529 from per1234/efficient-artifact-replacement
Use more efficient workflow artifact replacement approach
2 parents f5c8353 + 2a4704a commit 4e7a852

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

workflow-templates/publish-go-nightly-task.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ jobs:
196196
path: ${{ env.DIST_DIR }}
197197

198198
- name: Create checksum file
199-
working-directory: ${{ env.DIST_DIR}}
199+
working-directory: ${{ env.DIST_DIR }}
200200
run: |
201201
TAG="nightly-$(date -u +"%Y%m%d")"
202202
sha256sum ${{ env.PROJECT_NAME }}_${TAG}* > ${TAG}-checksums.txt

workflow-templates/release-go-crosscompile-task.yml

+3-7
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,6 @@ jobs:
120120
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
121121
path: ${{ env.DIST_DIR }}
122122

123-
- name: Remove non-notarized artifact
124-
uses: geekyeggo/delete-artifact@v5
125-
with:
126-
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
127-
128123
- name: Import Code-Signing Certificates
129124
env:
130125
KEYCHAIN: "sign.keychain"
@@ -192,11 +187,12 @@ jobs:
192187
-C "${{ env.BUILD_FOLDER }}/" "${{ env.PROJECT_NAME }}" \
193188
-C ../../ LICENSE.txt
194189
195-
- name: Upload notarized artifact
190+
- name: Replace artifact with notarized build
196191
uses: actions/upload-artifact@v4
197192
with:
198193
if-no-files-found: error
199194
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
195+
overwrite: true
200196
path: ${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
201197

202198
create-release:
@@ -216,7 +212,7 @@ jobs:
216212
pattern: ${{ env.ARTIFACT_PREFIX }}*
217213

218214
- name: Create checksum file
219-
working-directory: ${{ env.DIST_DIR}}
215+
working-directory: ${{ env.DIST_DIR }}
220216
run: |
221217
TAG="${GITHUB_REF/refs\/tags\//}"
222218
sha256sum ${{ env.PROJECT_NAME }}_${TAG}* > ${TAG}-checksums.txt

workflow-templates/release-go-task.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ jobs:
203203
path: ${{ env.DIST_DIR }}
204204

205205
- name: Create checksum file
206-
working-directory: ${{ env.DIST_DIR}}
206+
working-directory: ${{ env.DIST_DIR }}
207207
run: |
208208
TAG="${GITHUB_REF/refs\/tags\//}"
209209
sha256sum ${{ env.PROJECT_NAME }}_${TAG}* > ${TAG}-checksums.txt

0 commit comments

Comments
 (0)