Skip to content

Commit 0afb419

Browse files
committed
Remove unused job outputs from release workflows
In a previous revision of the release workflows, the updated checksums were determined by the macOS notarization job and then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code that declares the job outputs was not removed at that time. The checksum job output declaration code is now unused (and unusable since the checksum determination and output definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the vestigial code is hereby removed from the workflows.
1 parent 4393dba commit 0afb419

File tree

3 files changed

+0
-11
lines changed

3 files changed

+0
-11
lines changed

workflow-templates/publish-go-nightly-task.yml

-6
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,6 @@ jobs:
7373
name: Notarize ${{ matrix.build.folder-suffix }}
7474
runs-on: macos-latest
7575
needs: create-nightly-artifacts
76-
77-
outputs:
78-
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
79-
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
80-
8176
permissions:
8277
contents: read
8378

@@ -165,7 +160,6 @@ jobs:
165160
gon "${{ env.GON_CONFIG_PATH }}"
166161
167162
- name: Re-package binary
168-
id: re-package
169163
working-directory: ${{ env.DIST_DIR }}
170164
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
171165
run: |

workflow-templates/release-go-crosscompile-task.yml

-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ jobs:
182182
gon "${{ env.GON_CONFIG_PATH }}"
183183
184184
- name: Re-package binary
185-
id: re-package
186185
working-directory: ${{ env.DIST_DIR }}
187186
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
188187
run: |

workflow-templates/release-go-task.yml

-4
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ jobs:
8080
name: Notarize ${{ matrix.build.folder-suffix }}
8181
runs-on: macos-latest
8282
needs: create-release-artifacts
83-
outputs:
84-
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
85-
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
8683
permissions:
8784
contents: read
8885

@@ -172,7 +169,6 @@ jobs:
172169
gon "${{ env.GON_CONFIG_PATH }}"
173170
174171
- name: Re-package binary
175-
id: re-package
176172
working-directory: ${{ env.DIST_DIR }}
177173
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
178174
run: |

0 commit comments

Comments
 (0)