Bump Node version to 18 #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah!! same error as Node 20!! |
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the actions using Node 16 to Node 18
Why
GitHub is deprecating Node 16 for GitHub Actions. Therefore currently workflow runs using this action show the warning:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/[email protected].More information is found on GitHub Actions: Transitioning from Node 16 to Node 20
But the test suite uses the nock library to mock and expectations of the HTTP server, and it is not yet supported in Node 20. See: nock/nock#2466
Node 18 is in Maintenance LTS until 2025-04-30, so it can be useful, at least for a year.