Skip to content

Commit c438d0b

Browse files
committed
Remove redundant path joining
The code iterates through the folder containing the sketches reports. The iteration code returns the full path to each sketches report file. However, for some reason that path was joined to itself when it was passed to `open`. Fortunately the pathlib module is smart enough to handle the joining of two identical absolute paths so this didn't cause a problem but it is pointless and confusing so the redundant path joining code is removed.
1 parent 2a23433 commit c438d0b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

reportsizedeltas/reportsizedeltas.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ def get_sketches_reports(self, artifact_folder_object):
298298
sketches_reports = []
299299
for report_filename in sorted(artifact_folder.iterdir()):
300300
# Combine sketches reports into an array
301-
with open(file=report_filename.joinpath(report_filename)) as report_file:
301+
with open(file=report_filename) as report_file:
302302
report_data = json.load(report_file)
303303
if (
304304
(self.ReportKeys.boards not in report_data)

0 commit comments

Comments
 (0)