Skip to content

Commit 52c3d5f

Browse files
committed
Add "Accept" header to GitHub API HTTP requests
Providing this header is recommended by the GitHub REST API documentation.
1 parent 8a0046b commit 52c3d5f

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

reportsizedeltas/reportsizedeltas.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -625,8 +625,12 @@ def raw_http_request(self, url: str, data: bytes | None = None):
625625

626626
logger.info("Opening URL: " + url)
627627

628-
# GitHub recommends using user name as User-Agent (https://developer.github.com/v3/#user-agent-required)
629-
headers = {"Authorization": "token " + self.token, "User-Agent": self.repository_name.split("/")[0]}
628+
headers = {
629+
"Accept": "application/vnd.github+json",
630+
"Authorization": "token " + self.token,
631+
# GitHub recommends using user name as User-Agent (https://developer.github.com/v3/#user-agent-required)
632+
"User-Agent": self.repository_name.split("/")[0],
633+
}
630634
request = urllib.request.Request(url=url, headers=headers, data=data)
631635

632636
retry_count = 0

reportsizedeltas/tests/test_reportsizedeltas.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,13 @@ def test_raw_http_request(mocker):
888888
report_size_deltas.raw_http_request(url=url, data=data)
889889

890890
urllib.request.Request.assert_called_once_with(
891-
url=url, headers={"Authorization": "token " + token, "User-Agent": user_name}, data=data
891+
url=url,
892+
headers={
893+
"Accept": "application/vnd.github+json",
894+
"Authorization": "token " + token,
895+
"User-Agent": user_name,
896+
},
897+
data=data,
892898
)
893899
# URL is subject to GitHub API rate limiting
894900
report_size_deltas.handle_rate_limiting.assert_called_once()

0 commit comments

Comments
 (0)