Skip to content

Incorrect description of isWhitespace in website documentation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shurik179 opened this issue Oct 11, 2020 · 2 comments
Open

Incorrect description of isWhitespace in website documentation #44

shurik179 opened this issue Oct 11, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@shurik179
Copy link

Documentation of isWhitespace function on Arduino website says

Analyse if a char is a white space, that is space, formfeed ('\f'), newline ('\n'), carriage return ('\r'), horizontal tab ('\t'), and vertical tab ('\v')).

This is not correct. Implementation of isWhitespace function in arduino core defines it as a synonym of C function isblank, which only matches space and \t

@per1234 per1234 transferred this issue from arduino/Arduino Oct 11, 2020
@per1234 per1234 transferred this issue from arduino/reference-en Oct 11, 2020
@per1234
Copy link
Collaborator

per1234 commented Oct 11, 2020

Thanks so much for reporting this @shurik179!

This has already been fixed in the English language version of the Arduino Language Reference:
arduino/reference-en#595
However, the change has not been synced to this repository:
#6
so the error remains in the Turkish language version of the documentation.

If you submit a pull request to update the content, I would be happy to merge it. If you're conversant with Git, it should be a quick cherry-pick. Or just a copy/paste via the GitHub web interface is fast enough as well.
https://github.com/arduino/reference-tr/blob/master/Language/Functions/Characters/isWhitespace.adoc


Adding a reference to adafruit/Adafruit_nRF52_Arduino#593 to keep everything linked up.

@per1234 per1234 added the bug Something isn't working label Oct 11, 2020
@per1234
Copy link
Collaborator

per1234 commented Oct 11, 2020

You're looking at the page in the Turkish language version of the reference:
https://www.arduino.cc/reference/tr/language/functions/characters/iswhitespace/
note the "tr" in the URL. The reason it's in English is because the content for each translation starts as a copy of the English language content, then the translators work to translate it all to the target language. So this page has not yet been translated.

The English language version of the page is here:
https://www.arduino.cc/reference/en/language/functions/characters/iswhitespace/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants