remove useless stuff and implement callback functions to be implemented

Author: umbynos

dummy-monitor/main.go

@@ -18,10 +18,8 @@
 package main
 
 import (
-	"errors"
 	"fmt"
 	"os"
-	"time"
 
 	"github.com/arduino/go-properties-orderedmap"
 	monitor "github.com/arduino/pluggable-monitor-protocol-handler"
@@ -53,94 +51,30 @@ func (d *dummyMonitor) Hello(userAgent string, protocol int) error {
 	return nil
 }
 
-// Quit does nothing.
-// In a real implementation it can be used to tear down resources
-// used to monitor Ports.
-func (d *dummyMonitor) Quit() {}
-
 //TODO implement
-func (d *dummyMonitor) Describe() {
-
+func (d *dummyMonitor) Describe() (*monitor.PortDescriptor, error) {
+	return nil, nil
 }
 
 //TODO implement
-func (d *dummyMonitor) Configure() {
-
+func (d *dummyMonitor) Configure(parameterName string, value string) error {
+	return nil
 }
 
 //TODO implement
-func (d *dummyMonitor) Open() {
-
+func (d *dummyMonitor) Open(ipAddress string, boardPort string) error {
+	return nil
 }
 
 //TODO implement
-func (d *dummyMonitor) Close() {
-
-}
-
-//TODO remove
-// Stop is used to stop the goroutine started by StartSync
-// used to discover ports.
-func (d *dummyMonitor) Stop() error {
-	if d.closeChan != nil {
-		d.closeChan <- true
-		close(d.closeChan)
-		d.closeChan = nil
-	}
+func (d *dummyMonitor) Close() error {
 	return nil
 }
 
-//TODO remove
-// StartSync starts the goroutine that generates fake Ports.
-func (d *dummyMonitor) StartSync(eventCB monitor.EventCallback, errorCB monitor.ErrorCallback) error {
-	d.startSyncCount++
-	if d.startSyncCount%5 == 0 {
-		return errors.New("could not start_sync every 5 times")
-	}
-
-	c := make(chan bool)
-	d.closeChan = c
-
-	// Run synchronous event emitter
-	go func() {
-		var closeChan <-chan bool = c
-
-		// Output initial port state
-		eventCB("add", createDummyPort())
-		eventCB("add", createDummyPort())
-
-		// Start sending events
-		count := 0
-		for count < 2 {
-			count++
-
-			select {
-			case <-closeChan:
-				return
-			case <-time.After(2 * time.Second):
-			}
-
-			port := createDummyPort()
-			eventCB("add", port)
-
-			select {
-			case <-closeChan:
-				return
-			case <-time.After(2 * time.Second):
-			}
-
-			eventCB("remove", &monitor.Port{
-				Address:  port.Address,
-				Protocol: port.Protocol,
-			})
-		}
-
-		errorCB("unrecoverable error, cannot send more events")
-		<-closeChan
-	}()
-
-	return nil
-}
+// Quit does nothing.
+// In a real implementation it can be used to tear down resources
+// used to monitor Ports.
+func (d *dummyMonitor) Quit() {}
 
 var dummyCounter = 0
 

monitor.go

@@ -55,10 +55,20 @@ type Monitor interface {
 	// and the protocolVersion negotiated with the client.
 	Hello(userAgent string, protocolVersion int) error
 
+	// Describe is called to obtain the description of the comunication port
 	Describe() (*PortDescriptor, error)
 
+	// Configure allows to set the configuration parameters for the comunication port
+	Configure(parameterName string, value string) error
+
+	// Open allows to open a comunication with the board using TCP/IP
+	Open(ipAddress string, boardPort string) error
+
+	// Close will close the currently open port and TCP/IP connection
+	Close() error
+
 	// Quit is called just before the server terminates. This function can be
-	// used by the monitor as a last chance gracefully close resources.
+	// used by the monitor as a last chance to gracefully close resources.
 	Quit()
 }
 
@@ -109,6 +119,14 @@ func (d *Server) Run(in io.Reader, out io.Writer) error {
 		switch cmd {
 		case "HELLO":
 			d.hello(fullCmd[6:])
+		case "DESCRIBE":
+			d.describe()
+		case "CONFIGURE":
+			d.configure(fullCmd[10:])
+		case "OPEN":
+			d.open(fullCmd[5:])
+		case "CLOSE":
+			d.close()
 		case "QUIT":
 			d.impl.Quit()
 			d.outputChan <- messageOk("quit")
@@ -149,6 +167,22 @@ func (d *Server) hello(cmd string) {
 	d.initialized = true
 }
 
+func (d *Server) describe() {
+
+}
+
+func (d *Server) configure(cmd string) {
+
+}
+
+func (d *Server) open(cmd string) {
+
+}
+
+func (d *Server) close() {
+
+}
+
 func (d *Server) errorEvent(msg string) {
 	d.outputChan <- messageError("start_sync", msg)
 }