Skip to content

Commit 714c121

Browse files
committed
Fix LED on/off logic
1 parent 376c880 commit 714c121

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

app/board.h

+6
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@
7373
#define BOARD_RED_LED PK_5
7474
#define BOARD_BLUE_LED PK_7
7575

76+
#define BOARD_LED_OFF 1
77+
7678
#define BOARD_USB_RESET PJ_4
7779
#define BOARD_ETH_RESET PJ_15
7880
#define BOARD_BOOT_SEL PI_8
@@ -142,6 +144,8 @@
142144
#define BOARD_RED_LED PE_3
143145
#define BOARD_BLUE_LED PF_4
144146

147+
#define BOARD_LED_OFF 1
148+
145149
#define BOARD_USB_RESET PA_2
146150

147151
#define BOARD_I2C_SCL PF_1
@@ -209,6 +213,8 @@
209213
#define BOARD_RED_LED PH_11
210214
#define BOARD_BLUE_LED PE_5
211215

216+
#define BOARD_LED_OFF 0
217+
212218
#define BOARD_ETH_RESET PJ_15
213219

214220
#define BOARD_USBD_VID 0x2341

app/main.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ volatile const uint8_t bootloader_identifier[] __attribute__ ((section (".bootlo
6969
USBD_HandleTypeDef USBD_Device;
7070
#endif
7171

72-
DigitalOut red(BOARD_RED_LED, 1);
73-
DigitalOut green(BOARD_GREEN_LED, 1);
74-
DigitalOut blue(BOARD_BLUE_LED, 1);
72+
DigitalOut red(BOARD_RED_LED, BOARD_LED_OFF);
73+
DigitalOut green(BOARD_GREEN_LED, BOARD_LED_OFF);
74+
DigitalOut blue(BOARD_BLUE_LED, BOARD_LED_OFF);
7575

7676
#if defined (BOARD_BOOT_SEL)
7777
DigitalIn boot_sel(BOARD_BOOT_SEL,PullDown);
@@ -84,9 +84,9 @@ bool debug_enabled = false;
8484

8585
static void led_swap_feedback_off(void) {
8686
swap_ticker.detach();
87-
red = 1;
88-
green = 1;
89-
blue = 1;
87+
red = BOARD_LED_OFF;
88+
green = BOARD_LED_OFF;
89+
blue = BOARD_LED_OFF;
9090
}
9191

9292
static void led_swap_feedback() {

0 commit comments

Comments
 (0)