Skip to content

Adding roo_prefs to repositories.txt #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Adding roo_prefs to repositories.txt #4947

merged 1 commit into from
Aug 6, 2024

Conversation

dejwk
Copy link
Contributor

@dejwk dejwk commented Aug 6, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

ERROR: Arduino Lint found errors with https://github.com/dejwk/roo_prefs:

Linting library in roo_prefs
INFO: No header file found matching library name (roo_collections.h). Best practices are for primary header filename to 
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name roo_collections is in use by a library in the Library Manager index. Each library must have a unique
       name value. If your library is already in the index, use the "--library-manager update" flag.                    
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @dejwk
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dejwk
Copy link
Contributor Author

dejwk commented Aug 6, 2024

Linter problem fixed, @ArduinoBot.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/dejwk/roo_prefs:

Linting library in roo_prefs
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

@github-actions github-actions bot merged commit 7bcdb71 into arduino:main Aug 6, 2024
12 checks passed
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/dejwk/roo_prefs/

github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant