Skip to content

Update repositories.txt #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Update repositories.txt #4887

merged 3 commits into from
Jul 31, 2024

Conversation

BlairBlaidd
Copy link
Contributor

Library to support Newhaven display DZW series character displays using SPI communication.

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 30, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/BlairBlaidd/Libraries/tree/main/Newhaven_CharacterOLED_SPI

ERROR: Submission URL is not a Git clone URL (e.g., https://github.com/arduino-libraries/Servo).

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @BlairBlaidd
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello . Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

A problem was found with your submission https://github.com/BlairBlaidd/Libraries/tree/main/Newhaven_CharacterOLED_SPI

ERROR: Submission URL is not a Git clone URL (e.g., https://github.com/arduino-libraries/Servo).

As explained in the documentation:

What are the requirements for a library to be added to Library Manager?

  • The library.properties file must be located in the root of the repository.

This means that you must use a dedicated repository for each library rather than mashing a bunch of libraries into a single repository.

So please move the library to the root of the repository's folder structure and plan to use this repository for the development of that library alone. You will find this is a much more sensible approach in the end anyway (GitHub gives unlimited free repositories so there is no benefit in trying to put multiple unrelated projects in a single repo).

You will need to do the following things:

  1. Fix the repository structure.
  2. Create a new release or tag in the library repository.
  3. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 30, 2024
Copy link
Contributor

Hi @BlairBlaidd
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added topic: invalid Request could not be processed and removed status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list labels Jul 31, 2024
@github-actions github-actions bot requested a review from per1234 July 31, 2024 16:44
@BlairBlaidd
Copy link
Contributor Author

@ArduinoBot the repository file structure was fixed.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Hi @BlairBlaidd
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added topic: submission Add library to the list and removed topic: invalid Request could not be processed labels Jul 31, 2024
@github-actions github-actions bot removed the request for review from per1234 July 31, 2024 16:57
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/BlairBlaidd/Newhaven_CharacterOLED_SPI:

Linting library in Newhaven_CharacterOLED_SPI
WARNING: library.properties name value Newhaven_CharacterOLED_SPI is longer than the recommended length of 16           
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Newhaven_CharacterOLED_SPI/examples/HelloOLEDWorld

Linter results for project: no errors or warnings

-------------------

Linting sketch in Newhaven_CharacterOLED_SPI/examples/Newhaven_OLED_SPI

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 663a08d into arduino:main Jul 31, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/BlairBlaidd/Newhaven_CharacterOLED_SPI/

github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants