Skip to content

The lib didn't update after new tag drafted #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Forairaaaaa opened this issue Jun 13, 2022 · 2 comments
Closed

The lib didn't update after new tag drafted #1486

Forairaaaaa opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels
conclusion: invalid Issue/PR not valid type: imperfection Perceived defect in any part of project

Comments

@Forairaaaaa
Copy link

Forairaaaaa commented Jun 13, 2022

Hi,
I update my lib to a new tag few days ago, but i still can't see the update in the ArduinoIDE. So, I tried draft a new tag hours ago, but ArduinoIDE still maintains the old version of the lib. Could you please have a check and point out where I did wrong?
https://github.com/m5stack/M5-CoreInk.git
Thanks

@per1234 per1234 transferred this issue from arduino/Arduino Jun 13, 2022
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Jun 13, 2022
@per1234 per1234 self-assigned this Jun 13, 2022
@per1234
Copy link
Contributor

per1234 commented Jun 13, 2022

Hi @Forairaaaaa

Problem

The problem is shown here in the "M5-CoreInk" library's dedicated indexer logs web page:

2022/06/13 08:18:22 Checking out tag: 0.0.4
2022/06/13 08:18:23 Release M5-CoreInk:0.0.3 already loaded, skipping

Unfortunately, the logs don't communicate about this particular thing very well, but what this tells us is that the version value in the library.properties metadata file was not updated before creating the 0.0.4 tag (note that the indexer checked out tag 0.0.4, only to find the release version was 0.0.3).

You can see it here:

https://github.com/m5stack/M5-CoreInk/library.properties#L2

version=0.0.3

Even though Git tags are the unit of release for the Arduino Library Manager, all versioning is done according to the version field of the library.properties file. For this reason, the indexer will reject any tag that has the same value in its version field as a release already in the index.

Solution

The solution is to make another release of the library which meets the requirements:

  1. Update the version value in library.properties to the version that will be used for the new release.
  2. Create a new release or tag in the library repository.

The indexer system will pick up that new release and it will be available from Library Manager within a day. The non-compliant release will still be missing, but since the newer release will be available, that is no problem.

Please let me know if you have any questions or concerns.
Regards, Per

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2022
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Jun 13, 2022
@Forairaaaaa
Copy link
Author

Hi @Forairaaaaa

Problem

The problem is shown here in the "M5-CoreInk" library's dedicated indexer logs web page:

2022/06/13 08:18:22 Checking out tag: 0.0.4
2022/06/13 08:18:23 Release M5-CoreInk:0.0.3 already loaded, skipping

Unfortunately, the logs don't communicate about this particular thing very well, but what this tells us is that the version value in the library.properties metadata file was not updated before creating the 0.0.4 tag (note that the indexer checked out tag 0.0.4, only to find the release version was 0.0.3).

You can see it here:

https://github.com/m5stack/M5-CoreInk/library.properties#L2

version=0.0.3

Even though Git tags are the unit of release for the Arduino Library Manager, all versioning is done according to the version field of the library.properties file. For this reason, the indexer will reject any tag that has the same value in its version field as a release already in the index.

Solution

The solution is to make another release of the library which meets the requirements:

  1. Update the version value in library.properties to the version that will be used for the new release.
  2. Create a new release or tag in the library repository.

The indexer system will pick up that new release and it will be available from Library Manager within a day. The non-compliant release will still be missing, but since the newer release will be available, that is no problem.

Please let me know if you have any questions or concerns. Regards, Per

Thanks a lot! I'll try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants