From 20968a8ed441b1cf330d0df92a1446d95d708ab6 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 21 Mar 2022 03:36:14 -0700 Subject: [PATCH] Adjust release workflow for new "v"-prefixed tag format The Go modules system requires the release Git tags to start with a "v" prefix. Historically, this project has used the otherwise more sensible approach of using the exact version number as a tag name. This meant that the module could only be used as a dependency via "pseudo-versions". For example, `go get github.com/arduino/libraries-repository-engine@latest` currently adds this travesty to your `go.mod` file: ```text require github.com/arduino/libraries-repository-engine v0.0.0-20220321045648-4999750bf965 ``` This causes several problems: - Unstable non-release versions of the module are more likely to be used by dependent projects - Automated release update services (i.e., Dependabot) are not available, resulting in dependent projects using outdated versions of the module The release workflow was configured for the previous non-prefixed tag format, so it must be adjusted for the new "v" prefixed tag format. --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d006369f..feea36b6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,7 +7,7 @@ env: on: push: tags: - - "[0-9]+.[0-9]+.[0-9]+*" + - "v[0-9]+.[0-9]+.[0-9]+*" jobs: release: @@ -58,7 +58,7 @@ jobs: - name: Create changelog uses: arduino/create-changelog@v1 with: - tag-regex: '^[0-9]+\.[0-9]+\.[0-9]+.*$' + tag-regex: '^v?[0-9]+\.[0-9]+\.[0-9]+.*$' filter-regex: '^\[(skip|changelog)[ ,-](skip|changelog)\].*' case-insensitive-regex: true changelog-file-path: ${{ env.CHANGELOG_PATH }}