Skip to content

Commit 20968a8

Browse files
committed
Adjust release workflow for new "v"-prefixed tag format
The Go modules system requires the release Git tags to start with a "v" prefix. Historically, this project has used the otherwise more sensible approach of using the exact version number as a tag name. This meant that the module could only be used as a dependency via "pseudo-versions". For example, `go get github.com/arduino/libraries-repository-engine@latest` currently adds this travesty to your `go.mod` file: ```text require github.com/arduino/libraries-repository-engine v0.0.0-20220321045648-4999750bf965 ``` This causes several problems: - Unstable non-release versions of the module are more likely to be used by dependent projects - Automated release update services (i.e., Dependabot) are not available, resulting in dependent projects using outdated versions of the module The release workflow was configured for the previous non-prefixed tag format, so it must be adjusted for the new "v" prefixed tag format.
1 parent 4999750 commit 20968a8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ env:
77
on:
88
push:
99
tags:
10-
- "[0-9]+.[0-9]+.[0-9]+*"
10+
- "v[0-9]+.[0-9]+.[0-9]+*"
1111

1212
jobs:
1313
release:
@@ -58,7 +58,7 @@ jobs:
5858
- name: Create changelog
5959
uses: arduino/create-changelog@v1
6060
with:
61-
tag-regex: '^[0-9]+\.[0-9]+\.[0-9]+.*$'
61+
tag-regex: '^v?[0-9]+\.[0-9]+\.[0-9]+.*$'
6262
filter-regex: '^\[(skip|changelog)[ ,-](skip|changelog)\].*'
6363
case-insensitive-regex: true
6464
changelog-file-path: ${{ env.CHANGELOG_PATH }}

0 commit comments

Comments
 (0)