Apply task go:lint suggestions

Author: MatteoPologruto

Diff for: devicenotification/devicenotification.go

@@ -42,15 +42,15 @@ import (
 	"golang.org/x/sys/windows"
 )
 
-var osThreadId atomic.Uint32
+var osThreadID atomic.Uint32
 
 // Start the device add/remove notification process, at every event a call to eventCB will be performed.
 // This function will block until interrupted by the given context. Errors will be passed to errorCB.
 // Returns error if sync process can't be started.
 func Start(ctx context.Context, eventCB func(), errorCB func(msg string)) error {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
-	osThreadId.Store(windows.GetCurrentThreadId())
+	osThreadID.Store(windows.GetCurrentThreadId())
 
 	eventsChan := make(chan bool, 1)
 	var eventsChanLock sync.Mutex
@@ -108,24 +108,24 @@ func Start(ctx context.Context, eventCB func(), errorCB func(msg string)) error
 
 	go func() {
 		<-ctx.Done()
-		_ = win32.PostMessage(windowHandle, win32.WM_Quit, 0, 0)
+		_ = win32.PostMessage(windowHandle, win32.WMQuit, 0, 0)
 	}()
 
 	for {
 		// Verify running thread prerequisites
-		if currThreadId := windows.GetCurrentThreadId(); currThreadId != osThreadId.Load() {
-			panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadId, osThreadId))
+		if currThreadID := windows.GetCurrentThreadId(); currThreadID != osThreadID.Load() {
+			panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadID, osThreadID))
 		}
 
 		var m win32.TagMSG
-		if res := win32.GetMessage(&m, windowHandle, win32.WM_Quit, win32.WM_Quit); res == 0 { // 0 means we got a WM_QUIT
+		if res := win32.GetMessage(&m, windowHandle, win32.WMQuit, win32.WMQuit); res == 0 { // 0 means we got a WMQUIT
 			break
 		} else if res == -1 { // -1 means that an error occurred
 			err := windows.GetLastError()
 			errorCB("error consuming messages: " + err.Error())
 			break
 		} else {
-			// we got a message != WM_Quit, it should not happen but, just in case...
+			// we got a message != WMQuit, it should not happen but, just in case...
 			win32.TranslateMessage(&m)
 			win32.DispatchMessage(&m)
 		}
@@ -136,8 +136,8 @@ func Start(ctx context.Context, eventCB func(), errorCB func(msg string)) error
 
 func createWindow(windowCallback win32.WindowProcCallback) (syscall.Handle, *byte, error) {
 	// Verify running thread prerequisites
-	if currThreadId := windows.GetCurrentThreadId(); currThreadId != osThreadId.Load() {
-		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadId, osThreadId.Load()))
+	if currThreadID := windows.GetCurrentThreadId(); currThreadID != osThreadID.Load() {
+		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadID, osThreadID.Load()))
 	}
 
 	moduleHandle, err := win32.GetModuleHandle(nil)
@@ -167,8 +167,8 @@ func createWindow(windowCallback win32.WindowProcCallback) (syscall.Handle, *byt
 
 func destroyWindow(windowHandle syscall.Handle, className *byte) error {
 	// Verify running thread prerequisites
-	if currThreadId := windows.GetCurrentThreadId(); currThreadId != osThreadId.Load() {
-		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadId, osThreadId.Load()))
+	if currThreadID := windows.GetCurrentThreadId(); currThreadID != osThreadID.Load() {
+		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadID, osThreadID.Load()))
 	}
 
 	if err := win32.DestroyWindowEx(windowHandle); err != nil {
@@ -182,8 +182,8 @@ func destroyWindow(windowHandle syscall.Handle, className *byte) error {
 
 func registerNotifications(windowHandle syscall.Handle) (syscall.Handle, error) {
 	// Verify running thread prerequisites
-	if currThreadId := windows.GetCurrentThreadId(); currThreadId != osThreadId.Load() {
-		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadId, osThreadId.Load()))
+	if currThreadID := windows.GetCurrentThreadId(); currThreadID != osThreadID.Load() {
+		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadID, osThreadID.Load()))
 	}
 
 	notificationFilter := win32.DevBroadcastDeviceInterface{
@@ -203,8 +203,8 @@ func registerNotifications(windowHandle syscall.Handle) (syscall.Handle, error)
 
 func unregisterNotifications(notificationsDevHandle syscall.Handle) error {
 	// Verify running thread prerequisites
-	if currThreadId := windows.GetCurrentThreadId(); currThreadId != osThreadId.Load() {
-		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadId, osThreadId.Load()))
+	if currThreadID := windows.GetCurrentThreadId(); currThreadID != osThreadID.Load() {
+		panic(fmt.Sprintf("this function must run on the main OS Thread: currThread=%d, osThread=%d", currThreadID, osThreadID.Load()))
 	}
 
 	if err := win32.UnregisterDeviceNotification(notificationsDevHandle); err != nil {

Diff for: doc.go

@@ -27,6 +27,6 @@
  * the GNU General Public License.
  */
 
-// win32 is a collection of useful bindings to Win32 API that are not available in the standard
+// Package win32 is a collection of useful bindings to Win32 API that are not available in the standard
 // golang windows/syscall package.
 package win32

Diff for: syscall_windows.go

@@ -262,7 +262,7 @@ type TagMSG struct {
 	LPrivate int32
 }
 
-const WM_Quit = 0x0012
+const WMQuit = 0x0012
 
 const WsExDlgModalFrame = 0x00000001
 const WsExTopmost = 0x00000008
@@ -272,7 +272,7 @@ const WsExToolWindow = 0x00000080
 const WsExAppWindow = 0x00040000
 const WsExLayered = 0x00080000
 
-type Guid struct {
+type GUID struct {
 	Data1 uint32
 	Data2 uint16
 	Data3 uint16
@@ -283,12 +283,12 @@ type DevBroadcastDeviceInterface struct {
 	DwSize       uint32
 	DwDeviceType uint32
 	DwReserved   uint32
-	ClassGUID    Guid
+	ClassGUID    GUID
 	SzName       uint16
 }
 
-// USB devices GUID used to filter notifications
-var UsbEventGUID Guid = Guid{
+// UsbEventGUID is USB devices GUID used to filter notifications
+var UsbEventGUID GUID = GUID{
 	Data1: 0x10bfdca5,
 	Data2: 0x3065,
 	Data3: 0xd211,
@@ -301,8 +301,8 @@ const DeviceNotifyAllInterfaceClasses = 4
 
 const DbtDevtypeDeviceInterface = 5
 
-const PM_NoRemove = 0x0000
-const PM_Remove = 0x0001
-const PM_NoYield = 0x0002
+const PMNoRemove = 0x0000
+const PMRemove = 0x0001
+const PMNoYield = 0x0002
 
 type WindowProcCallback func(hwnd syscall.Handle, msg uint32, wParam uintptr, lParam uintptr) uintptr