Nicla Vision Proximity tutorial: Update with clearer installing instructions #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions to install the library were very sparse. I learned much more from the README file in the pololu repo (https://github.com/pololu/vl53l1x-arduino). I pulled similar language into this document to help others who come after me.
|
|
|
@marqdevx Is this the correct library that is referenced? |
sebromero
requested changes
Mar 14, 2022
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
Yes, it is also linked inside the meta data of the article. |
marqdevx
changed the title
marqdevx
added
fix/update
…ity/content.md committing suggestion by sebromero Co-authored-by: Sebastian Romero <[email protected]>
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
…ity/content.md Co-authored-by: Josefine Hansson <[email protected]>
…ity/content.md Co-authored-by: Josefine Hansson <[email protected]>
Co-authored-by: Josefine Hansson <[email protected]>
sebromero
approved these changes
Mar 17, 2022
content/hardware/05.nicla/boards/nicla-vision/tutorials/proximity/content.md
Outdated
Show resolved
Hide resolved
|
@rkertesz Hi Ruben 👋 Thank you for your contribution. If you're happy with the suggestions that we've added we can merge this PR. |
|
@sebromero changes look good. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions to install the library were very sparse. I learned much more from the README file in the pololu repo (https://github.com/pololu/vl53l1x-arduino). I pulled similar language into this document to help others who come after me.
What Needs To Be Reviewed
Some readme language