From c07866db889bb4bb1c1e42488206e724366f146d Mon Sep 17 00:00:00 2001 From: Silvano Cerza Date: Tue, 5 Jan 2021 10:49:34 +0100 Subject: [PATCH 1/2] Fix regexes flags set uncorrectly --- src/settings.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/settings.ts b/src/settings.ts index 71db8ae..6dbca39 100644 --- a/src/settings.ts +++ b/src/settings.ts @@ -15,9 +15,12 @@ export interface Settings { export async function initSettings(): Promise { const settings = {} as Settings settings.gitPath = await io.which('git', true) - const caseInsensitive = core.getInput('case-insensitive-regex') - settings.tagRegex = RegExp(core.getInput('tag-regex'), caseInsensitive) - settings.filterRegex = RegExp(core.getInput('filter-regex'), caseInsensitive) + let regexFlag = '' + if (core.getInput('case-insensitive-regex') === 'true') { + regexFlag = 'i' + } + settings.tagRegex = RegExp(core.getInput('tag-regex'), regexFlag) + settings.filterRegex = RegExp(core.getInput('filter-regex'), regexFlag) settings.changelogFilePath = core.getInput('changelog-file-path') || 'CHANGELOG.md' return settings } From b4e7d15eafeaa34f38baa93968cbe3c0fc4754bb Mon Sep 17 00:00:00 2001 From: Silvano Cerza Date: Tue, 5 Jan 2021 10:50:24 +0100 Subject: [PATCH 2/2] Change case-insensitive-regex property default to false --- README.md | 2 +- action.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b081d66..80b5d21 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ The action accepts some properties: changelog-file-path: 'MyChangelog.md' ``` -- `case-insensitive-regex` to make both `tag-regex` and `filter-regex` case insensitive, defaults to `true`. +- `case-insensitive-regex` to make both `tag-regex` and `filter-regex` case insensitive, defaults to `false`. ``` - name: Create Changelog diff --git a/action.yml b/action.yml index a3ae93f..d6ca60a 100644 --- a/action.yml +++ b/action.yml @@ -19,4 +19,4 @@ inputs: default: 'CHANGELOG.md' case-insensitive-regex: description: 'If true both tag-regex and filter-regex are case insensitive' - default: true + default: false