Skip to content

Commit 81cb201

Browse files
authored
Fix regexes flags set incorrectly (#3)
* Fix regexes flags set uncorrectly * Change case-insensitive-regex property default to false
1 parent 56fcc22 commit 81cb201

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ The action accepts some properties:
4242
changelog-file-path: 'MyChangelog.md'
4343
```
4444

45-
- `case-insensitive-regex` to make both `tag-regex` and `filter-regex` case insensitive, defaults to `true`.
45+
- `case-insensitive-regex` to make both `tag-regex` and `filter-regex` case insensitive, defaults to `false`.
4646

4747
```
4848
- name: Create Changelog

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ inputs:
1919
default: 'CHANGELOG.md'
2020
case-insensitive-regex:
2121
description: 'If true both tag-regex and filter-regex are case insensitive'
22-
default: true
22+
default: false

src/settings.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,12 @@ export interface Settings {
1515
export async function initSettings(): Promise<Settings> {
1616
const settings = {} as Settings
1717
settings.gitPath = await io.which('git', true)
18-
const caseInsensitive = core.getInput('case-insensitive-regex')
19-
settings.tagRegex = RegExp(core.getInput('tag-regex'), caseInsensitive)
20-
settings.filterRegex = RegExp(core.getInput('filter-regex'), caseInsensitive)
18+
let regexFlag = ''
19+
if (core.getInput('case-insensitive-regex') === 'true') {
20+
regexFlag = 'i'
21+
}
22+
settings.tagRegex = RegExp(core.getInput('tag-regex'), regexFlag)
23+
settings.filterRegex = RegExp(core.getInput('filter-regex'), regexFlag)
2124
settings.changelogFilePath = core.getInput('changelog-file-path') || 'CHANGELOG.md'
2225
return settings
2326
}

0 commit comments

Comments
 (0)