Skip to content

Commit 85afb5b

Browse files
committed
Move definition of package filename to dedicated step in release workflow
The package filename is referenced in multiple places in the release workflow. In order to avoid code duplication, it is defined once as an environment variable, then that variable referenced in each of the instances where the filename is needed. Previously, this was done by first defining and referencing a shell environment variable at the point of the first usage, then defining a workflow environment variable and referencing that in the second usage. The maintainability and readability of the workflow is improved by using a single workflow environment variable, defined in the step dedicated to defining such variables, then referencing it consistently in all usages.
1 parent 4e5bcdb commit 85afb5b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/release-go-crosscompile-task.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ jobs:
9595
run: |
9696
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
9797
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >> "$GITHUB_ENV"
98+
TAG="${GITHUB_REF/refs\/tags\//}"
99+
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >> $GITHUB_ENV
100+
98101
- name: Checkout repository
99102
uses: actions/checkout@v4
100103

@@ -167,10 +170,7 @@ jobs:
167170
# GitHub's upload/download-artifact actions don't preserve file permissions,
168171
# so we need to add execution permission back until the action is made to do this.
169172
chmod +x "${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"
170-
TAG="${GITHUB_REF/refs\/tags\//}"
171-
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}"
172-
tar -czvf "$PACKAGE_FILENAME" "${{ env.BUILD_FOLDER }}/"
173-
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
173+
tar -czvf "${{ env.PACKAGE_FILENAME }}" "${{ env.BUILD_FOLDER }}/"
174174
175175
- name: Upload artifact
176176
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)