As a user I want to be notified by the IDE when saving the editor content has failed.

[kittaakos]

This is a follow-up task of #379

@DeeEmm wrote here:

the bar is actually yellow as predicted and if I save the document (CMD-S) the file modified date does not change

On macOS (maybe other OSs are also affected), the backend process could crash after waking up the system from sleep. This issue has been identified and fixed in the Theia IDE framework and the new IDE's nightly build also contains this fix. However, it is not always obvious to the users what has happened and what to do.

• First off, we have to fix the dirty indicator bug in Theia: The (editor's) dirty indicator is not visible when the widget is closeable: false eclipse-theia/theia#8692
• We have to raise a toast error message to the user when saving the editor content has failed.

[kittaakos]

Depends on #315.

[kittaakos]

I have some updates on this issue. (Please also check the work in progress screencast. I've forcefully killed the process that does the file system save.)

• We show a warning status bar, plus the Offline status.
• We show the dirty indicator (•) in the editor if it contains unsaved changes.
• We toast an error message; saving the sketch has failed.

[DeeEmm]

Awesome work @kittaakos

[ubidefeo]

good one, @kittaakos

let's reword that message to make sure the user understand that it's a bug.
Also can we intercept the user closing the window/IDE and do something about it?
Just asking for a friend 👍

[kittaakos]

let's reword that message to make sure the user understand that it's a bug.

Sure. What kind of message do you want to see? Please advise.

Also can we intercept the user closing the window/IDE and do something about it?

Sorry, I do not understand it; can you please clarify? Thank you!

[ubidefeo]

Also can we intercept the user closing the window/IDE and do something about it?
Sorry, I do not understand it; can you please clarify? Thank you!

we should prevent the user from quitting the IDE without notifying that current content will be lost.
Even better would be to handle this like Sublime Text does, it keeps files in a temporary state until properly saved, but maybe it's convoluted

[kittaakos]

Even better would be to handle this like Sublime Text does, it keeps files in a temporary state until properly saved, but maybe it's convoluted

I cannot much more agree. That is exactly how the Theia framework should behave. VS Code switched to that behavior as well. unload and beforeunload events are deprecated and do not work reliably in the browser window: https://developers.google.com/web/updates/2018/07/page-lifecycle-api#events

[kittaakos]

VS Code switched to that behavior as well.

Interesting, the VS Code guys just revived this feature in the 1.51.0 release: https://code.visualstudio.com/updates/v1_51#_prevent-accidental-close

[ubidefeo]

Interesting, the VS Code guys just revived this feature in the 1.51.0 release: https://code.visualstudio.com/updates/v1_51#_prevent-accidental-close

boom!

[kittaakos]

we should prevent the user from quitting the IDE without notifying that current content will be lost.

We will show a different dialog detail when quitting the app, and closing the app after an unrecoverable error:

Even better would be to handle this like Sublime Text does, it keeps files in a temporary state until properly saved, but maybe it's convoluted

It's a brilliant idea but is a giant feature and should be handled by the Theia framework.

[kittaakos]

It's done.