Skip to content

Add checks #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 10, 2020
Merged

Add checks #92

merged 10 commits into from
Dec 10, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 7, 2020

No description provided.

@per1234 per1234 requested review from rsora and silvanocerza December 7, 2020 10:30
silvanocerza
silvanocerza suggested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small things to change but the rest if good

@per1234 per1234 force-pushed the per1234/add-checks branch from 56172b6 to 171133b Compare December 7, 2020 19:46
per1234 added 10 commits December 8, 2020 20:50
@per1234
Add dedicated test data for library without examples
c6db61e 
Previously, tests that needed a library without examples used a library that just happened to not have examples for test
data. Using test data specifically intended to provide the necessary conditions will result in less fragile tests.
@per1234
Add check for missing library examples
2118c62
@per1234
Add checks for missing license file
dd2966d 
If a file with one of the names supported by the licensee gem is in the root of the repository containing the text of a
standard license, GitHub recognizes the license type and enables some nice integrations. So having such a file is best
practices.

These checks are only for the presence of the file, rather than their contents.
@per1234
Add check for missing readme in platforms
b81f90c
@per1234
Add checks for incorrect Arduino.h filename case in #include directives
48a30d5
@per1234
Add functions to provide check data for sketches
a18fef1
@per1234
Add check for sketch.json invalid JSON document
351c554
@per1234
Add check for sketch.json invalid data format
6ce9b3b 
This checks whether sketch.json is compliant with the expected data format.
@per1234
Add check for sketch name mismatch
5a56b42
@per1234
Add check for forgotten library.properties version bump
0ebcb78
@per1234 per1234 force-pushed the per1234/add-checks branch from 171133b to 0ebcb78 Compare December 9, 2020 04:51
@per1234 per1234 merged commit e48c2be into main Dec 10, 2020
@per1234 per1234 deleted the per1234/add-checks branch December 10, 2020 09:49
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees

@per1234 per1234

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @silvanocerza