From 104501ed135b6e6701ae63b1a92ac88a2316f378 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 14 Oct 2024 16:05:43 -0700 Subject: [PATCH] Remove unused job outputs from release workflows In a previous revision of the release workflows, the updated checksums were determined by the macOS notarization job and then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code that declares the job outputs was not removed at that time. The checksum job output declaration code is now unused (and unusable since the checksum determination and output definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the vestigial code is hereby removed from the workflows. --- .github/workflows/publish-go-nightly-task.yml | 6 ------ .github/workflows/release-go-task.yml | 4 ---- 2 files changed, 10 deletions(-) diff --git a/.github/workflows/publish-go-nightly-task.yml b/.github/workflows/publish-go-nightly-task.yml index 75203701..f6b8a84b 100644 --- a/.github/workflows/publish-go-nightly-task.yml +++ b/.github/workflows/publish-go-nightly-task.yml @@ -72,11 +72,6 @@ jobs: name: Notarize ${{ matrix.build.folder-suffix }} runs-on: macos-latest needs: create-nightly-artifacts - - outputs: - checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }} - checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }} - permissions: contents: read @@ -163,7 +158,6 @@ jobs: gon "${{ env.GON_CONFIG_PATH }}" - name: Re-package binary - id: re-package working-directory: ${{ env.DIST_DIR }} # Repackage the signed binary replaced in place by Gon (ignoring the output zip file) run: | diff --git a/.github/workflows/release-go-task.yml b/.github/workflows/release-go-task.yml index 1a0733a9..8a9bf858 100644 --- a/.github/workflows/release-go-task.yml +++ b/.github/workflows/release-go-task.yml @@ -79,9 +79,6 @@ jobs: name: Notarize ${{ matrix.build.folder-suffix }} runs-on: macos-latest needs: create-release-artifacts - outputs: - checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }} - checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }} permissions: contents: read @@ -170,7 +167,6 @@ jobs: gon "${{ env.GON_CONFIG_PATH }}" - name: Re-package binary - id: re-package working-directory: ${{ env.DIST_DIR }} # Repackage the signed binary replaced in place by Gon (ignoring the output zip file) run: |