-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add check for symlinks in library #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e80dfb
to
bd49d86
Compare
bd49d86
to
7a62024
Compare
I think this feature might be broken: I just tested version 1.1.4 with a repository that contains a symlink, but it didn't detect it. |
Hi @bblanchon can you tell us which repo so we can test it? |
Hi @silvanocerza, It was ArduinoJson, but I removed the symlink a few hours ago, so you'll have to check out the tag |
I tested it a bit. Seems like rule Probably we need to clarify the rule or make it work for directories too. @per1234 what do you think? |
We prohibit any type of symlink in libraries, so this must be fixed: Thanks for the report @bblanchon! |
You're welcome, @per1234. |
That is correct. We now provide a dedicated web page with the indexer logs for each of the Library Manager libraries. You can see the logs for ArduinoJson here:
|
Thanks, @per1234. I didn't know the log files were publicly accessible; this is awesome! |
No description provided.